Skip to content

Commit

Permalink
Debug shortcut polish
Browse files Browse the repository at this point in the history
* Avoid  F5(continue debug) shortctut conflicting with  refresh all by switching  QKeySequence:Refresh to Ctrl+R.
* Confirm debug arg dialog using Ctrl+Return
* Add Stop debug action to debug menu in main menu bar
  • Loading branch information
karliss committed Jan 30, 2025
1 parent de575df commit 8ef0590
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/MainWindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,7 @@ void MainWindow::initUI()
connect(seek_to_func_start_shortcut, &QShortcut::activated, this,
&MainWindow::seekToFunctionStart);

QShortcut *refresh_shortcut = new QShortcut(QKeySequence(QKeySequence::Refresh), this);
connect(refresh_shortcut, &QShortcut::activated, this, &MainWindow::refreshAll);
ui->actionRefresh_contents->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_R));

connect(ui->actionZoomIn, &QAction::triggered, this, &MainWindow::onZoomIn);
connect(ui->actionZoomOut, &QAction::triggered, this, &MainWindow::onZoomOut);
Expand Down Expand Up @@ -298,6 +297,7 @@ void MainWindow::initToolBar()
ui->menuDebug->addAction(debugActions->actionStartEmul);
ui->menuDebug->addAction(debugActions->actionAttach);
ui->menuDebug->addAction(debugActions->actionStartRemote);
ui->menuDebug->addAction(debugActions->actionStop);
ui->menuDebug->addSeparator();
ui->menuDebug->addAction(debugActions->actionStep);
ui->menuDebug->addAction(debugActions->actionStepOver);
Expand Down
4 changes: 4 additions & 0 deletions src/dialogs/NativeDebugDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@
#include "ui_NativeDebugDialog.h"

#include <QMessageBox>
#include <QShortcut>

NativeDebugDialog::NativeDebugDialog(QWidget *parent)
: QDialog(parent), ui(new Ui::NativeDebugDialog)
{
ui->setupUi(this);
setWindowFlags(windowFlags() & (~Qt::WindowContextHelpButtonHint));
auto shortcut = new QShortcut(QKeySequence(Qt::CTRL | Qt::Key_Return), ui->argEdit, nullptr,
nullptr, Qt::ShortcutContext::WidgetShortcut);
connect(shortcut, &QShortcut::activated, this, &QDialog::accept);
}

NativeDebugDialog::~NativeDebugDialog() {}
Expand Down

0 comments on commit 8ef0590

Please sign in to comment.