Update rizin to latest dev #3418
Draft
+103
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant breaking changes in rizin: rz_str_escape_utf8_keep_printable: 29e25fd895d605d82540f5d4aefdac277422b077 plugin hash tables: 30953d3bf677c20ba60831202fe78298144efe1f rz_core_debug_continue_until: 87b75910b5b8224e3eebb73c0eb22cf19a05798b rz_core_get_boundaries_prot: 266fe6b3c701946a24b2e478246bdd1f38cac844 search commands: 710a33b6efd14813c8ed2d91449268ab25a529bc
karliss
requested changes
Mar 1, 2025
Comment on lines
2514
to
2515
| QStringList plugins; | ||
| RzListIter *iter; |
There was a problem hiding this comment.
Unused iter? Same for other plugin list hashtable changes.
Rot127
requested changes
Mar 7, 2025
| @@ -62,6 +62,16 @@ struct CUTTER_EXPORT RegisterRef | |||
| QString name; | |||
| }; | |||
|
|
|||
| enum class SearchSpace | |||
There was a problem hiding this comment.
Would rename it to "SearchElementType" or something. Because in Rizin the "search space" means: bytes or graphs or knowledge base.
There was a problem hiding this comment.
See search_internal.h::RzSearchSpace
Comment on lines
+3938
to
+3940
| case SearchSpace::String: | ||
| cmd = "/zj"; | ||
| break; |
There was a problem hiding this comment.
Adding regex search would be trivial here, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Not yet fully completed:
Relevant breaking changes in rizin:
rz_str_escape_utf8_keep_printable: 29e25fd895d605d82540f5d4aefdac277422b077
plugin hash tables: 30953d3bf677c20ba60831202fe78298144efe1f
rz_core_debug_continue_until: 87b75910b5b8224e3eebb73c0eb22cf19a05798b
rz_core_get_boundaries_prot: 266fe6b3c701946a24b2e478246bdd1f38cac844
search commands: 710a33b6efd14813c8ed2d91449268ab25a529bc