Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing VFP-v3/Neon D0-D31 registers (#4589) #4592

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add missing VFP-v3/Neon D0-D31 registers (#4589) #4592

merged 1 commit into from
Aug 16, 2024

Conversation

ahmed-hany94
Copy link
Contributor

@ahmed-hany94 ahmed-hany94 commented Aug 15, 2024 •
edited by wargio
Loading

SQUASH ME

Per issue #4589: DWARF: Missing some ARM32 registers VFP-v3/Neon D0-D31 registers were missing from map_dwarf_reg_to_arm32 causing

WARNING: (libr/arch/isa/arm/arm_dwarf_regnumb_table.h:137):
map_dwarf_reg_to_arm32: code should not be reached

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

wargio
wargio reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a weird diff.

wargio
wargio requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the issue: Please push the changes using UNIX line delimiters. not windows ones.

@wargio wargio force-pushed the add-arm32-vfp-v3-neon-registers branch from 24610d4 to 70e0193 Compare August 16, 2024 02:59
@wargio wargio self-requested a review August 16, 2024 02:59
wargio
wargio approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the line ending, squash is mandatory

@ahmed-hany94
Add missing VFP-v3/Neon D0-D31 registers
0488df2 
Per [issue: DWARF: Missing some ARM32
registers](rizinorg#4589)
VFP-v3/Neon D0-D31 registers were missing from map_dwarf_reg_to_arm32
causing

```
WARNING: (libr/arch/isa/arm/arm_dwarf_regnumb_table.h:137):
map_dwarf_reg_to_arm32: code should not be reached
```
@ahmed-hany94 ahmed-hany94 force-pushed the add-arm32-vfp-v3-neon-registers branch from 70e0193 to 0488df2 Compare August 16, 2024 03:39
@Rot127 Rot127 merged commit d1b71f4 into rizinorg:dev Aug 16, 2024
44 checks passed
@ahmed-hany94 ahmed-hany94 deleted the add-arm32-vfp-v3-neon-registers branch August 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

Assignees
No one assigned
Labels
ARM RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmed-hany94 @wargio @Rot127