Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a magic number #17

Merged
merged 2 commits into from
Apr 18, 2013
Merged

Remove a magic number #17

merged 2 commits into from
Apr 18, 2013

Conversation

rentalcustard
Copy link

No description provided.

@rkh
Copy link
Owner

rkh commented Apr 17, 2013

I like how this makes the port configurable.

@rentalcustard
Copy link
Author

Now mergeable. Oh, and it totally removes duplication now.

@rkh
Copy link
Owner

rkh commented Apr 18, 2013

No longer mergeable.

Pro tip: Instead of "#{$z}" you can just use "#$z".

@rentalcustard
Copy link
Author

MERGEABLE

rkh added a commit that referenced this pull request Apr 18, 2013
@rkh
Merge pull request #17 from mortice/refactoring-harder
511fc25 
Remove a magic number
@rkh rkh merged commit 511fc25 into rkh:master Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rentalcustard @rkh