Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc #91

Merged
merged 3 commits into from
Nov 25, 2024
+31 −15
Merged

Misc #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28ae160
Don't need target-version when we already have requires-python
rkhwaja Nov 25, 2024
beec85a
Use setup-uv in place of setup-python
rkhwaja Nov 25, 2024
ff46b11
Document ruff rule ignores
rkhwaja Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,16 @@ jobs:
python-version: [3.8, 3.9, "3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Checkout repository
uses: actions/checkout@v4
- name: Install uv
uses: yezz123/setup-uv@v4
uses: astral-sh/setup-uv@v3
- name: Set up Python ${{ matrix.python-version }}
run: uv python install ${{ matrix.python-version }}
- name: Dependencies
run: |
uv sync --no-cache
run: uv sync --no-cache
- name: Lint
run: |
uv run poe lint
run: uv run poe lint
- name: Tests
env:
GOOGLEDRIVEFS_TEST_CLIENT_ID: ${{ secrets.GOOGLEDRIVEFS_TEST_CLIENT_ID }}
Expand All @@ -64,7 +61,7 @@ jobs:
NGROK_AUTH_TOKEN: ${{ secrets.NGROK_AUTH_TOKEN }}
if: ${{needs.secrets.outputs.valid}} == 'true'
run: |
if python --version | grep -q 'Python 3.13' ; then
if uv run python --version | grep -q 'Python 3.13' ; then
uv run poe test
fi
- name: Coverage
Expand Down
27 changes: 23 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,32 @@ coverage xml

[tool.ruff]
line-length = 200
lint.ignore = ["ANN", "D", "DTZ", "EM102", "ERA001", "FBT002", "FIX", "G004", "I", "N", "PT009", "PT027", "PT013", "PTH", "S101", "TCH003", "TD", "TRY003", "W191"]
lint.ignore = [
"ANN", # Requires annotations
"D", # Requires various docstrings
"DTZ", # flake8-datetimez
"EM102", # Disallows f-strings in exceptions
"ERA001", # Disallows commented out code
"FBT002", # Disallows boolean positional arguments
"FIX", # Disallows FIXME-type comments
"G004", # Disallows using f-strings in log strings
"I", # False positive isort complaints
"N", # PEP8 naming rules
"PT009", # Use of unittest assertions - but they come from the `fs` package
"PT013", # Requires pytest to be imported in a specific way
"PT027", # Use of unittest assertions - but they come from the `fs` package
"PTH", # Requires use of pathlib
"S101", # Disallows use of assert
"TD", # Requires a particular formatting of TODO comments
"TRY003", # Disallows long exception messages
"W191", # Disallows tab indentation
]
lint.select = ["ALL"]
target-version = "py38"

[tool.ruff.lint.extend-per-file-ignores]
"__init__.py" = ["F401"]
"tests/*" = ["ANN201", "D103", "INP001", "PT006"]
"__init__.py" = [
"F401", # Unused import
]

[tool.ruff.lint.flake8-quotes]
inline-quotes = "single"
Expand Down
Loading