fix: occasional 500 error when being scraped for metrics #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing errors on the /metrics end-point suggesting that the same metric is attempted to being exported more than once during the same collect.
I suspect this is because the ttlcache.Range() function doesn't grab a mutex for the entire loop, and that the cleanup or other modication is causing the same values to be emitted more than once during the same iteration.
This change gets a copy of the map then iterates over that, and hopefully stops that error condition from manifesting itself.
(We'll keep an eye on for a while to see if this re-occurs, but wanted to open the PR early in case the previous change is breaking anyone else)