logging #125
Merged
logging #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 1, 2023 10:08
If there is an exception while running a mode, print to log, generate plot (if there is anything to plot) and continue with next mode.
ebus_toolbox/__main__.py
Outdated
| print(f"Writing log to {log_path}") | ||
| log_handlers.append(logging.FileHandler(log_path)) | ||
| logging.basicConfig( | ||
| level=vars(logging)[args.loglevel], |
There was a problem hiding this comment.
Could splitting file and stream logging levels be useful?
There was a problem hiding this comment.
This is a question for @j-brendel. In my opinion, it should not be split, as both should display the same (the file log is just the captured console log). And it is more difficult to separate these two.
There was a problem hiding this comment.
Moved this issue here: #127
- logging.warning instead of logging.warn (deprecated) - correct spelling of SpiceEV - remove DEBUG logging of matplotlib - move logging setup to util
PaulScheerRLI
approved these changes
Jun 2, 2023
j-brendel
reviewed
Jul 28, 2023
| @@ -87,6 +87,15 @@ default_buffer_time_opps = 0 | |||
| # Options: HV, HV/MV, MV, MV/LV, LV (default: MV) | |||
| default_voltage_level = "MV" | |||
|
|
|||
| ##### LOGGING ##### | |||
There was a problem hiding this comment.
The file created has ANSI encoding on my PC. Is it possible to change to UTF-8 (hardcoded?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging to file in addition to console output. Can be configured:
--helpor logging docu for all options.nullto disable file logging.All warnings are written to log as well.
If there is an exception during a mode, it is written to the logfile (with traceback), a plot is generated (if there is anything to plot) and the program continues with the next mode (if possible).