Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing input files to output #208

Merged
merged 6 commits into from
Sep 20, 2024
Merged

add missing input files to output #208

merged 6 commits into from
Sep 20, 2024

Conversation

stefansc1
Copy link
Collaborator

@stefansc1 stefansc1 commented Aug 7, 2024 •
edited
Loading

More input files are saved to output directory. So far:

  • input schedule (trips.csv)
  • consumption (mileage if given in vehicle_types)
  • temperature
  • level of loading
  • electrified station PV
  • electrified station fixed load
  • electrified station price
  • time windows
  • rotation_filter
  • station optimization (optimizer config and others)
  • station_data (mainly elevation?)
    general price (unsupported SpiceEV option)

j-brendel
j-brendel requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@j-brendel j-brendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Otherwise fine

simba/__main__.py Show resolved Hide resolved
j-brendel
j-brendel approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@j-brendel j-brendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@j-brendel j-brendel merged commit 3531dc9 into dev Sep 20, 2024
6 checks passed
@j-brendel j-brendel deleted the fix/add_missing_input_files branch September 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-brendel j-brendel j-brendel approved these changes

@PaulScheerRLI PaulScheerRLI Awaiting requested review from PaulScheerRLI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefansc1 @j-brendel