Make lol and temperatures optional. make cfg parameter backwards compatible #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er names backwards compatible Simulation can run without temperatures and lol if vehicle_types have constant mileage. vehicle types with mileage look up will fail late. Arguments expanded with deprecated values which replace current values. Warning for deprecation is given. Station Height data lookup will give errors in case station is missing from station_data. in other cases a single warning is given if no station data is provided
…tional_timeseries_and_compatibility
Refactor deprecation utility
…tional_timeseries_and_compatibility # Conflicts: # simba/__main__.py # simba/data_container.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulation can run without temperatures and level of loadings if vehicle_types have constant mileage.
If vehicle types with mileage look need one of these values during simulation, the simulation will fail. Test added to check this feature.
Deprecated arguments:
can be used again, but will throw a warning to use the updated naming.
Station Height data lookup will give errors in case station is missing from station_data. In other cases a single warning is given if no station data is provided.