Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility patch for SpiceEV PR #217 #214

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

stefansc1
Copy link
Collaborator

refactor costs PR: rl-institut/spice_ev#217

  • rename cost_calculation_strategy_X to cost_calculation_method_X
  • use cost calc types instead of strategy names
  • create window timeseries for PLW costs
  • test: remove peak_shaving cost calc test (also fixed_wo_plw, so no different to greedy/balanced), fixed_w_plw generates same el. costs

refactor costs rl-institut/spice_ev#217
- rename cost_calculation_strategy_X to cost_calculation_method_X
- use cost calc types instead of strategy names
- create window timeseries for PLW costs
- test: remove peak_shaving cost calc test (also fixed_wo_plw, so no different to greedy/balanced), fixed_w_plw generates same el. costs
Copy link
Collaborator

@PaulScheerRLI PaulScheerRLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Tests will work with updated spiceev i presume

docs/source/simulation_parameters.rst Outdated Show resolved Hide resolved
data/examples/simba.cfg Show resolved Hide resolved
Copy link
Collaborator

@j-brendel j-brendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@j-brendel j-brendel merged commit 598b02c into dev Oct 16, 2024
6 checks passed
@j-brendel j-brendel deleted the feature/spice_ev_refactor_costs branch October 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants