Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#181 #184 update sliders app settings #188

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

nesnoj
Copy link
Member

@nesnoj nesnoj commented Aug 31, 2023

Fixes #181
Fixes #184

Before merging into dev-branch, please make sure that the following points are checked:

  • All pre-commit tests passed locally with: pre-commit run -a
  • File CHANGELOG.md was updated
  • The docs were updated
    • if dataset.mds were updated, the dataset docs were regenerated using
      python docs/generate_dataset_mds.py

If packages were modified:

  • File poetry.lock was updated with: poetry lock
  • A new env was successfully set up

WARNING: When modifying use snakemake <=7.32.0, cf. #186

If data flow was adjusted:

  • Data pipeline run finished successfully with: snakemake -jX

  • Esys appdata was created successfully with: snakemake -jX make_esys_appdata

    (with X = desired number of cores, e.g. 1)

@nesnoj nesnoj self-assigned this Aug 31, 2023
@nesnoj nesnoj merged commit c310e39 into dev Aug 31, 2023
@nesnoj nesnoj deleted the features/#181_#184_update_sliders_app_settings branch August 31, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restricted heat pump sliders to not move under 50 Add central HP targets to slider
1 participant