Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function to ignore gitkeep files; delete zip in case of download error #193

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

dvdstrzl
Copy link
Collaborator

Before merging into dev-branch, please make sure that the following points are checked:

  • All pre-commit tests passed locally with: pre-commit run -a
  • File CHANGELOG.md was updated
  • The docs were updated
    • if dataset.mds were updated, the dataset docs were regenerated using
      python docs/generate_dataset_mds.py

If packages were modified:

  • File poetry.lock was updated with: poetry lock
  • A new env was successfully set up

WARNING: When modifying use snakemake <=7.32.0, cf. #186

If data flow was adjusted:

  • Data pipeline run finished successfully with: snakemake -jX

  • Esys appdata was created successfully with: snakemake -jX make_esys_appdata

    (with X = desired number of cores, e.g. 1)

@nesnoj nesnoj self-requested a review September 19, 2023 06:59
Copy link
Member

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@nesnoj nesnoj merged commit a217e1b into dev Sep 19, 2023
@nesnoj nesnoj deleted the fix/optimize_update_raw branch September 19, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants