Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating technology data dataset.md #194

Merged
merged 13 commits into from
Oct 9, 2023
Merged

Conversation

aaronschilling
Copy link
Contributor

@aaronschilling aaronschilling commented Oct 4, 2023

Fixes #

Updating dataset.md of technology data.
Created metadata file.

Before merging into dev-branch, please make sure that the following points are checked:

  • All pre-commit tests passed locally with: pre-commit run -a
    • black failed: Executable black not found
  • File CHANGELOG.md was updated
  • The docs were updated
  • if dataset.mds were updated, the dataset docs were regenerated using
    python docs/generate_dataset_mds.py

If packages were modified:

  • File poetry.lock was updated with: poetry lock
  • A new env was successfully set up

WARNING: When modifying use snakemake <=7.32.0, cf. #186

If data flow was adjusted:

  • Data pipeline run finished successfully with: snakemake -jX

  • Esys appdata was created successfully with: snakemake -jX make_esys_appdata

    (with X = desired number of cores, e.g. 1)

Copy link
Member

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this exhaustive docs!
I changed some format stuff and added some sources.

@nesnoj nesnoj merged commit 0d36326 into dev Oct 9, 2023
@nesnoj nesnoj deleted the updating_technology_data_dataset.md branch October 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants