Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated op parameter with predicate #337

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

MaGering
Copy link
Collaborator

With this PR the Future warning

sys:1: FutureWarning: The `op` parameter is deprecated and will be removed in a future release. Please use the `predicate` parameter instead.

is removed by using the parameter predicate instead of op.

@MaGering MaGering added the enhancement New feature or request label Aug 30, 2023
@MaGering MaGering added this to the v0.0.3 milestone Aug 30, 2023
@MaGering MaGering self-assigned this Aug 30, 2023
@MaGering
Copy link
Collaborator Author

MaGering commented Aug 30, 2023

Outdated: Checks not working due to problem described in my comment here. Hence this PR should be merged after #336.

Checks pass as of the state of commit 0e667a2.

@MaGering
Copy link
Collaborator Author

Ready for review @Stefanie08!

Copy link
Collaborator

@Stefanie08 Stefanie08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the FutureWarning. The changes work as expected, although new FutureWarnings are raised. A new issue will follow.

@MaGering
Copy link
Collaborator Author

Thank you for fixing the FutureWarning. The changes work as expected, although new FutureWarnings are raised. A new issue will follow.

Thanks for checking @Stefanie08.

If I execute the rule which belongs to this PR

snakemake -j1 prepare_conv_pp

I do not get any further Future Warnings. Note that to test this rule, all files except oemof-B3/results/_resources/scal_costs_efficiencies.csv must be there.

If there are other FutureWarnings, you need to identify at which rule they occur. You can do this from the output in the console or the log file.
Please only create an issue in the oemof-B3 repo if it is a FutureWarning that is triggered by code used in this repo. If it is a FutureWarning triggered in demandlib for example, you would have to create an issue there. Thanks a lot!

@MaGering MaGering merged commit 59dac6d into dev Sep 11, 2023
1 check passed
@MaGering MaGering deleted the fix/geopandas_future_warning branch September 11, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants