Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix by adapting output path handling #341

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix by adapting output path handling #341

merged 4 commits into from
Sep 11, 2023

Conversation

MaGering
Copy link
Collaborator

Resolves #303

The file type is added twice to the file name and hence the output can never be build by snakemake. With this commit the file path is set according to the file type in the settings.

This PR fixes the issue. Is only working with changes in PR #336.

@MaGering
Fix by adapting output path handling
9837e29 
The file type is added twice to the file name and hence the output can never be build by snakemake.
With this commit the file path is set according to the file type in the settings.
@MaGering MaGering added the bug Something isn't working label Aug 30, 2023
@MaGering MaGering added this to the v0.0.3 milestone Aug 30, 2023
@MaGering MaGering self-assigned this Aug 30, 2023
@MaGering
Copy link
Collaborator Author

MaGering commented Aug 30, 2023 •
edited
Loading

Outdated: Again checks not working due to problem described in my comment here. Hence this PR should be merged after #336.

Checks pass as of the state of commit 5e400b2.

@MaGering
Copy link
Collaborator Author

Ready for your review @Stefanie08!

You need the changes in PR #336 for your review. To be checked with

snakemake -j1 plot_all_resources

or

snakemake -j1 results/_resources/plots/scal_conv_pp-capacity_net_el.png

Thanks!

Stefanie08
Stefanie08 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@Stefanie08 Stefanie08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both commands work as expected.
Just as a side note:
There is also a typing error in the legend

grafik

@MaGering
Copy link
Collaborator Author

Both commands work as expected. Just as a side note: There is also a typing error in the legend

grafik

Thanks @Stefanie08. And for creating issue #348.

@MaGering MaGering merged commit 8ab28c7 into dev Sep 11, 2023
1 check passed
@MaGering MaGering deleted the fix/plot_all_resources branch September 11, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefanie08 Stefanie08 Stefanie08 approved these changes

Assignees

@MaGering MaGering

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.0.3
Development

Successfully merging this pull request may close these issues.

Rule plot_all_resources stopped working
2 participants
@MaGering @Stefanie08