Feature/equate variable for same optimisation #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bachibouzouk
commented
Oct 7, 2024
| @@ -117,6 +117,7 @@ def build_solph_components(self): | |||
| raise ValueError("Length mismatch between t_air and ghi profiles.") | |||
| # calculates the temperature factor values | |||
| pv_tf_values = [] | |||
| # TODO document those equations | |||
There was a problem hiding this comment.
@JulianBarinton - the conversion factor used here for PV panel seems faulty, do you know where this model comes from?
Bachibouzouk
commented
Oct 7, 2024
| name;type;carrier;tech;capacity;capacity_cost;marginal_cost;carrier_cost;from_bus;to_bus;t_air;ghi;p_rpv;r_ref;n_t;t_c_ref;noct;expandable | ||
| pv-panel;pv-panel;solar-energy;pv;0;0;0;0;solar-energy-bus;elec-bus;t-air;ghi;270;1000;-0.0037;25;48;False | ||
| name;type;carrier;tech;capacity;capacity_cost;marginal_cost;carrier_cost;capacity_potential;from_bus;to_bus;t_air;ghi;p_rpv;r_ref;n_t;t_c_ref;noct;expandable | ||
| pv-panel;pv-panel;solar-energy;pv;0;0;0;-0.1;100;solar-energy-bus;elec-bus;t-air;ghi;270;1000;-0.0037;25;48;True |
There was a problem hiding this comment.
I set negative costs to force pv-panel optimization for this usecase
Bachibouzouk
commented
Oct 7, 2024
| @@ -0,0 +1,2 @@ | |||
| name;type | |||
There was a problem hiding this comment.
This file is added to force PV Panel to match solar-radiation when optimized
Bachibouzouk
force-pushed
the
feature/equate-variable
branch
from
89624ca
to
0cdf209
Compare
Need to warn user if the PVPanel has existing capacity, otherwise solution is unbounded. The output power does not make any sense, there must be a typo The aggragated delivered power correspond to aggregated ghi multiplied by the optimized capacity
Bachibouzouk
force-pushed
the
feature/equate-variable
branch
from
0cdf209
to
f10d1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
We wanted to make sure the energy from the sun shining on a crop cannot be larger than the surface of the crop times the ghi of the sun
Type of change (CHANGELOG.md)
Added