Feature critical demand #165

adnanalakori · 2021-11-30T11:17:14Z

Adresses issue #162

The following subtasks have been implemented:

inputs/timeseries/test_site.csv

smartie2076 · 2021-12-01T08:31:12Z

Hi @adnanalakori! I edited the first post according to what is common use in github. There is a specific way to reference the issues that you are working on with a hashtag, and the to-do-list are clickable.

It may be that you do not want to adress each of tasks in this PR. Then delete some of the rows again. The PR can be closed if you can make sure that your changes do not interfere with the existing functionalities.

smartie2076

You did the first steps to implement the timeseries, let me know if you have trouble following though the next steps!

One remark: Your excel file as it is would not be helping you to implement the feature, as it calls column Demand four times

Instead of calling demand_ac_non_critical etc. which are the actual column heads of your demand profiles in inputs/timeseries/test_site.csv.

adnanalakori · 2021-12-01T10:56:34Z

Hi @smartie2076 , thanks! I unified names demand_ac_non_critical etc in the inputs/timeseries/test_site.csv, test_sitie.csv, and also constants in

offgridders/src/constants.py

Line 45 in a8fa6f1

TITLE_DEMAND_AC = "title_demand_ac"

The simulation up to now runs well and checked in simulation_experiments.csv.

smartie2076 · 2021-12-01T13:11:07Z

Can you upload the simulation_experiments.csv?

I wonder if it did load the timeseries of demand_ac_critical and demand_dc_critical (ie. a vector of 8760 entries), or only the title_demand. We need to make sure that it writes the vector to the data, so that you can process it later.

I think we might need to add it to https://github.com/rl-institut/offgridders/blob/dev/src/B_read_from_files.py#L551 in B, or also some processing in D0 to really get it into simulation_experiments.

(I am not sure if the following two points are really checked, or if some more work has to be done)

If not, needs to be implemented in D0 https://github.com/rl-institut/offgridders/blob/dev/src/D0_process_input.py

Check that timeseries was parsed correctly, add DEMAND_PROFILE_AC_CRITICAL and DEMAND_PROFILE_DC_CRITICAL
If you want an easier time to check whether or not the vectors/timeseries for the different demand categories are parsed, you could also have different timeseries for each of them (for now you just copied the columns in the timeseries input file).

adnanalakori · 2021-12-01T13:47:28Z

Can you upload the simulation_experiments.csv?

@smartie2076 , please find a cope of the simulation_experiments.csv attached. It seems up to now the title is shown:

Regarding the next point, I did not consider it as the new parameters have been shown in simulation_experiments.csv

If not, needs to be implemented in D0 https://github.com/rl-institut/offgridders/blob/dev/src/D0_process_input.py

Also same apply to this point -> I understood "parsed correctly" that the simulation run with no errors:_

Check that timeseries was parsed correctly, add DEMAND_PROFILE_AC_CRITICAL and DEMAND_PROFILE_DC_CRITICAL

smartie2076 · 2021-12-01T16:59:45Z

You do not have to quote reply all of it, just the parts you want to hightlight ;)

Ah, I realized that actually we can not figure out if it worked with sensitivity_experiments alone. :(
Can you upload the log-file? Directly with drag-and-drop, then I can also read it fully.

I am sure, actually, that we have to adapt this function:
`https://github.com/rl-institut/offgridders/blob/feature-critical-demand/src/D0_process_input.py#L234
...but, sadly, I was not very good at programming at this point, and there are very few logging messages, and the code is repetative. There are two options:

Just adapt everything that exists there for the initial title_demand_ac and title_demand_dc
Do it properly and generalize functions, to have less lines of code

There should definitly be more logging messages. So, try to understand the idea of the function and add some logging messages that help you understand which dara is added to the input data here. To observe what is changed in the function, you can add

import pp
pp.print(experiments_s)

Right below

offgridders/Offgridders.py

Line 117 in 4d21c9e

max_date_time_index, max_evaluated_days = process_input.add_timeseries(

, and then you can check if you added the timeseries properly.

You can also check if you can store the experiments_s as a json file, which would be easier to read:

    json_data = json.dumps(
        experiments_s,
        skipkeys=False,
        sort_keys=True,
        indent=4,
    )

smartie2076 · 2021-12-01T17:02:00Z

If you choose to improve the offgridders code and go for...

* Do it properly and generalize functions, to have less lines of code

You should push the related commits in a seperate PR, ideally WITHOUT the demand_ac_cricical, which we would then merge into dev. Then we pull the new, nice dev with improved functions and logging messages into this branch, and continue working. That way, this PR does not get heavy with "maintenance work" within the Offgridders code.

smartie2076

Hi @adnanalakori,

I added some comments in the code below. It is very important in python not to make the code more bulky and especcially important to try and avoid code duplications - write new functions instead, that you call multiple times. That way, you can also write unit tests for them and figure out if they work.

There are some logical errors, but I know that Offgridders is just big, it is hard to know what is going into where. Take special care when you change if-loops, and read the existing logging messages to figure out how the code should be changed.

I recommend you to add more logging.debug messages to your code to make sure that your changes make sense.

Did you check the experiment dict for the new information on the critical demand, and if it is parsed? This is very important, you need to know your code does what it should do before you go further and change stuff in other, later modules.

I think you error message might have to do with the fact that you completely removed the normal demand profile, and Offgridders can not parse the new critical ones jet. That is just a guess. If it persists, this PR is the right place to paste the full error message (not as a screenshot, either as a code or, if too long, as a txt).

smartie2076 · 2022-03-15T18:18:24Z

.gitignore

This file should not be commited.

smartie2076 · 2022-03-15T18:18:47Z

micro_grid_design_logfile.log.2021-12-02

@@ -0,0 +1,28 @@
+******************************************************


This file should not be commited.

src/B_read_from_files.py

smartie2076 · 2022-03-15T18:22:40Z

src/D0_process_input.py

+    TOTAL_DEMAND_AC_CRITICAL,
    PEAK_DEMAND_AC,
+    PEAK_DEMAND_AC_CRITICAL,
    TOTAL_DEMAND_DC,
+    TOTAL_DEMAND_DC_CRITICAL,
    PEAK_DEMAND_DC,
+    PEAK_DEMAND_DC_CRITICAL,
    PEAK_PV_GENERATION_PER_KWP,
    PEAK_WIND_GENERATION_PER_KW,
    MEAN_DEMAND_AC,
+    MEAN_DEMAND_AC_CRITICAL,
    MEAN_DEMAND_DC,
+    MEAN_DEMAND_DC_CRITICAL,
    PEAK_MEAN_DEMAND_RATIO_AC,
+    PEAK_MEAN_DEMAND_RATIO_AC_CRITICAL,
    PEAK_MEAN_DEMAND_RATIO_DC,
+    PEAK_MEAN_DEMAND_RATIO_DC_CRITICAL,
    ABS_PEAK_DEMAND_AC_SIDE,
+    ABS_PEAK_DEMAND_AC_CRITICAL_SIDE,


This is an executive decision - it seems you want to calculate the indicators for every demand type, an not aggregated? Fine by me, makes sense, but we will have to make sure that these parameters are also printed to the results file. This happens far at the end of the Offgridders process, though. Keep this comment open in Github as a reminder.

src/D0_process_input.py

smartie2076 · 2022-03-15T18:38:56Z

src/G1_oemof_create_model.py

+    # ------------demand sink ac critical ------------#
+    demand_ac_critical = generate.demand_ac_critical(
+        micro_grid_system, bus_electricity_ac, experiment[DEMAND_PROFILE_AC]
+    )
+
+    # ------------demand sink dc critical ------------#
+    demand_dc_critical = generate.demand_dc_critical(
+        micro_grid_system, bus_electricity_ac, experiment[DEMAND_PROFILE_DC]
+    )


You are defining new functions demand_ac_critical and demand_dc_critical here. However, those functions are absolutely identical - apart from the input argument of the demand. Create one single function for all these instances, ie. use a new function generate.demand() four times, for demand_ac, demand_dc, demand_ac_critical, demand_dc_critical. That is the pythonic way.

smartie2076 · 2022-03-15T18:40:00Z

src/G2a_oemof_busses_and_componets.py

@@ -745,6 +746,21 @@ def maingrid_feedin(micro_grid_system, experiment):
            )
        },
    )
+
+    def demand_dc_critical(micro_grid_system, bus_electricity_dc, demand_profile):


As described above, generalize these functions:

def demand(micro_grid_system, bus_electricity, demand_profile, profile_title): ...

src/constants.py

src/D0_process_input.py

adnanalakori · 2022-03-29T09:30:34Z

Hi @smartie2076 ,
It seems the error below because when we merged 4 similar functions in one and added demand_type in DO line 361, so we might need to mention it in line 476, would that help? Still not clear how it should be recognized as a demand for AC and DC and the demand_type have not been defined in constant.py?

def update_demand_profile(experiment_s, experiment, demand_profile, demand_type):
experiment_s[experiment].update(
{
demand_profile: pd.Series(
experiment_s[experiment][demand_type][0 : len(index)].values,
index=index,
)
return

smartie2076 · 2022-03-29T11:51:48Z

Hi @adnanalakori! Thanks for posting the issue here - it makes it easier to follow up on. Ideally, when posting issues here, you add links to the appropriate code passages, so that it is absolutely without possibility of error clear which lines of code you are referring to. For that, you open the file in github (here D0), go to the appropriate line, click on the line number, click on the three points and click "copy permalink":

I add the links below, so that we are for sure talking about the same thing.

merged 4 similar functions in one and added demand_type in DO line 361

We are talking about this function:

offgridders/src/D0_process_input.py

Line 361 in ab33623

    
           def update_demand_profile(experiment_s, experiment, demand_profile, demand_type):

Thing is, it is not a proper function definition - you can (almost) only define functions on the first level (no tabs in front of def), but here you define it within a if-elif-loop:

elif experiment_s[experiment][FILE_INDEX] == None:
            # limit based on index

            def update_demand_profile(experiment_s, experiment, demand_profile, demand_type):
                experiment_s[experiment].update(
                    {
                        demand_profile: pd.Series(
                            experiment_s[experiment][demand_type][0: len(index)].values,
                            index=index,
                        )
                    }
                )
                return

So, move this function out of your if-else-loop, and only call the function within this if-else-loop. Otherwise, the function is not recognized.

so we might need to mention it in line 476, would that help?

Line 476 would be this, so I guess the line where you got an error.

offgridders/src/D0_process_input.py

Line 476 in ab33623

ACCUMULATED_PROFILE_AC_SIDE: experiment_s[experiment][DEMAND_PROFILE_AC]

Still not clear how it should be recognized as a demand for AC and DC and the demand_type have not been defined in constant.py?

I think the problem is that you removed 4 similar code snippets and replaceAd them by D0.update_demand_profile, but then did not add the new calls of exactly this function - therefore, none of DEMAND_PROFILE_AC, DEMAND_PROFILE_DC, DEMAND_PROFILE_AC_CRITICAL, DEMAND_PROFILE_DC_CRITICAL are added to the experiment. Add the function calls, maybe this fixes the error.

adnanalakori · 2022-03-31T08:32:02Z

Add a constraint that allows shortage to replace non-critical demands (G2b)

Means adding constraint that allows capacity dispatch to supply critical load first and then non-critical load after that? The constraints shall work as a check point, correct?

adnanalakori · 2022-03-31T08:34:45Z

Think of KPI that represents how much non-critical demand is not covered. Should this be in total_shortage etc?

I assumed that the amount of “non-critical demand is not covered” is already fixed at input constant as scenarios e.g. 10% 30% etc.? Do we still need to apply a KPI here?

adnanalakori · 2022-03-31T08:36:34Z

Add plausability tests, ie. is critical demand always supplied, and is the shortage activated ADDITIONALLY? (G3a)

I assumed that the critical demand always supplied. Do we still to implement something here as well? could you elaborate on?

adnanalakori · 2022-03-31T08:42:39Z

Regarding model inputs and outputs, I could imagine the followings:

Model inputs:

We are willing to implement various shortages in the input constant excel file shortage_max_allowed
(10%, 30%, etc.). However this has to be applied only for non-critical load (we named it in our coding as DEMAND_AC and DEMAND_DC), is it ok?

Model outputs:

I assume that we are able to visualized electricity flow, etc. for both normal demand and critical demand as well, correct?
Techo-economic results will be the same as the current version of Offgridders?

smartie2076 · 2022-03-31T08:51:57Z

Add a constraint that allows shortage to replace non-critical demands (G2b)

Means adding constraint that allows capacity dispatch to supply critical load first and then non-critical load after that? The constraints shall work as a check point, correct?

Means that the shortage that is allowed can only be as high as non-critical load only, so that critical load is always supplied. The constraints are defined in G2b, but I would have to check more in detail what needs to be changed. It can be that the shortage is included implicitly within the stability constraints. In that case, all stability constraints need to be changed.

The constraint

offgridders/src/G2b_constraints_custom.py

Line 959 in 76173e0

    
           def timestep(model, case_dict, experiment, el_bus, sink_demand, source_shortage):

Is not implemented or used, so do not just change that, it will not help. However, it also seems to me that the "timestep" constraint is anyway added with

offgridders/src/G2a_oemof_busses_and_componets.py

Line 113 in 76173e0

def shortage(

? Because the nominal capacity, not the sum over the whole year is limited my the "max_shortage". I would have to put some time into this to know for sure. It would surprise me a bit, because if I have a household with blackouts, the simulation should terminate if the shortage source was not able to cover demand, but this did not happen.

Sidenote, can also be moved into an own issue

I would greatly appreciate if this PR could do a fix and rename the variable SHORTAGE_LIMIT to STABILITY_LIMIT. Maybe start here and replace all occurrences in the code.

offgridders/src/constants.py

Line 152 in 76173e0

SHORTAGE_LIMIT = "stability_limit"

I am not sure how this came to be, but it is very, very misleading in G2b, for example:

offgridders/src/G2b_constraints_custom.py

Line 64 in 76173e0

stability_limit = experiment[SHORTAGE_LIMIT]

smartie2076 · 2022-03-31T08:53:30Z

Add plausability tests, ie. is critical demand always supplied, and is the shortage activated ADDITIONALLY? (G3a)

I assumed that the critical demand always supplied. Do we still to implement something here as well? could you elaborate on?

Yeah, if you implement is correctly it is. But there are some parameters/KPI, that should take this into account - for example the % of shortage should then not be calculated based on shortage/non-cricitcal demand but `shortage/(non-critical + critical demand).

smartie2076 · 2022-03-31T08:55:03Z

Regarding model inputs and outputs, I could imagine the followings:

Model inputs:

* We are willing to  implement various shortages in the input constant excel file `shortage_max_allowed `
  (10%, 30%, etc.). However this has to be applied only for non-critical load (we named it in our coding as DEMAND_AC and DEMAND_DC), is it ok?

That is the idea.

Model outputs:

* I assumed that we are able to visualized electricity flow, etc. for both normal demand and critical demand as well, correct?

You have to implement this into the plots, only if you do it will be plotted.

* Techo-economic results will be the same as the current version of Offgridders?

Some KPI calculations might have to be changed, as they have the demand as a denominator, which currently is only the non-critical demand.

Bachibouzouk · 2022-04-04T07:59:32Z

Add a constraint that allows shortage to replace non-critical demands (G2b)

Means adding constraint that allows capacity dispatch to supply critical load first and then non-critical load after that? The constraints shall work as a check point, correct?

This would be added in G2b and called under # ------------Stability constraint------------# in G1.build (around line 400)?

smartie2076 · 2022-04-04T09:48:20Z

This would be added in G2b and called under # ------------Stability constraint------------# in G1.build (around line 400)?

Yeah it would. I am just not sure if it is basically already in the different stability constraints that I defined, or if it is not. Stability constraints would be:

offgridders/src/G2b_constraints_custom.py

Line 52 in 76173e0

def backup(

offgridders/src/G2b_constraints_custom.py

Line 242 in 76173e0

def hybrid(

offgridders/src/G2b_constraints_custom.py

Line 431 in 76173e0

def usage(

They are always written with a validity-check that has to pass after the optimization finished, eg:

offgridders/src/G2b_constraints_custom.py

Line 167 in 76173e0

def backup_test(case_dict, oemof_results, experiment, e_flows_df):

You would call the constraint in G1, if you did have to define a new constraint, I would probably add it at the end, so around here

offgridders/src/G1_oemof_create_model.py

Line 514 in 76173e0

    
               # ------------Allow shortage only for certain percentage of demand in a timestep------------#

Create a function to update the demand and not repeat code

Not exactly sure it is the right implementation, need to check that and modify if needed

Bachibouzouk · 2022-04-04T11:46:46Z

src/G2b_constraints_custom.py

+    """
+
+    def meet_critical_demand_rule(model):
+        # TODO express the fact that the critical demand must be met as a constraint


@smartie2076 - would something like this work? (Provided we then define total_production with arguments form the function

Yeah, this should work.

Bachibouzouk · 2022-04-04T11:54:29Z

src/G2a_oemof_busses_and_componets.py

-    )
+
+    stability_constraint = case_dict.get(STABILITY_CONSTRAINT, None)
+    if stability_constraint == CRITICAL:


I am not sure if this was the correct way to go with the shortage for critical demand @smartie2076

I am having issues with the naming here. stability_constraint should be a simplified electro-technical stability constraint, but here you are not assessing stability, but more something like a load_shedding option.

Also, here, you access the same stability_constraint value:

offgridders/src/G1_oemof_create_model.py

Line 406 in d7881b0

# ------------Stability constraint------------#

But this stability constraint is, for me, not the same as the load shedding option. Actually, as soon as you define non-critical demand, load shedding will per definitionem be allowed. This is also not very beautiful, but okay, as it is within the naming. You do not have to access the STABILITY_CONSTRAINT value for this.

I am not sure if allowing for load shedding will require all three stability constraints (share_backup, share_hybrid, share_usage) to be re-defined. Because, if there is intentional load-shedding, then it should be okay that also only a relative part of the remaining demand is covered by renewables or whatever. However, if 100% demand (critical+non-critical) is supplied, the share of renewables or whatever should be based on that effective demand. Meaning, all four (AC/DC critical/non-critical) demands need to be in the constraint - maybe the shortage asset then plays the deciding role here?

About shortage: I do not remember if this is the only part where it is implemented. In general, one needs to decide, whether load shedding of non-critical loads is considered shortage or not. I think right now, load shedding would be allowed within the margin of allowed shortage, effectively limiting its potential.

src/G1_oemof_create_model.py

adnanalakori · 2022-04-07T11:38:12Z

src/G0_oemof_simulate.py

+        e_flows_df = timeseries.get_demand(
+            case_dict,
+            oemof_results,
+            electricity_bus_ac,
+            electricity_bus_dc,
+            critical,
+            experiment,
+        )


@smartie2076 would that help for results plotting of the critical?

I don´t know, as I am not quite sure what your CRITICAL is right now - I did not find it in the code apart from something, where I thought it was a string only, not something added to the oemof model itself. I also don´t know what you are planning to plot...

Did the code run though with this new code bit? What results/graph did it generate?

The purpose is to separate, simulate and plot results of critical demand. This new function still did not run it yet, we still not sure about it yet.

I am sorry, I do not understand. I suggest that you create a blueprint plot with excel, to showcase what kind of graph you want to have generated.

Dont think I can help you here, though, as I am also not really in tune with the Offgridders code anymore.

In other words, offgridders shows power flow of the demand as in this figure below, in our case we want to show critical demand as well. That is all.

I think the "Demand" is supposed to be the total demand, including the DC and AC demand, and thus it should include critical demand as well. You just need to change the calculation of the "Demand". If you want to highlight that there is a specific (total) critical demand, I would suggest to add a dotted line of the same color as the total demand. The allowed shortage would then be the margin between those two lines.

adnanalakori · 2022-04-12T09:23:52Z

src/G1_oemof_create_model.py

    # TODO maybe important for critical
+    # AD: We might leave this certain of shortage to assign to the non critical demand?


Any suggestion here? @smartie2076

I am sorry, I do not understand the question.

In general, the question about allowed shortage, reliability and shedded load ends up in this questio: Is load shedding of non-critical loads considered shortage? If it is, then load shedding must be limited to the allowed shortage as defined in the input template. The resulting reliability will most often be equal to the allowed shortage. If load shedding is not considered shortage, I think it would still make sense that the reliability is then lower than if no load was shedded - so the above calculation should reflect that.

I suggest writing pytests or benchmark tests to make sure the feature is working properly and continues working properly in the future.

adnanalakori · 2022-04-12T09:24:58Z

src/G1_oemof_create_model.py

    # TODO maybe important for critical
+    # AD: We might leave this certain of shortage to assign to the non critical demand?
    """
    # ------------Allow shortage only for certain percentage of demand in a timestep------------#
    if case_dict['allow_shortage'] is True:


Any suggestion here? @smartie2076

adnanalakori · 2022-04-12T09:24:58Z

src/G1_oemof_create_model.py

    # TODO maybe important for critical
+    # AD: We might leave this certain of shortage to assign to the non critical demand?
    """
    # ------------Allow shortage only for certain percentage of demand in a timestep------------#
    if case_dict['allow_shortage'] is True:


Any suggestion here? @smartie2076

adnanalakori · 2022-04-26T11:11:25Z

src/G1_oemof_create_model.py

+    elif case_dict[STABILITY_CONSTRAINT] == CRITICAL:
+        # ADDED: a function to make the stability constraint favor critical demand over demand
+        logging.info(
+            "Added constraint: Stability though actual generation of diesel generators and backup through batteries."
+        )
+        constraints_custom.critical(
+            model,
+            case_dict,
+            experiment=experiment,
+            storage=storage,
+            sink_demand=sink_demand_ac,
+            genset=genset,
+            pcc_consumption=pointofcoupling_consumption,
+            source_shortage=source_shortage,
+            el_bus_ac=bus_electricity_ac,
+            el_bus_dc=bus_electricity_dc,


I am trying to add a function to make the stability constraint in favor critical demand, not sure!

smartie2076 · 2022-04-26T13:13:41Z

I just noticed that you should make sure that your code still works with the old input template - ie. that if title critical demand (etc) is not included, that value is set to None. Same for the old title demand AC/DC.

The aim is to compute the energy balance between production and consumption of each AC and DC busses and make sure there is enough energy to fullfill criticial demand at all timesteps

The triggering by critical constraint was wrong

TODO: adapt the code so that users not using critical demand do not recieve errors

if the critical demand option is on

Also move the color dict as a constant in G4 module

Work in progress to implement https://forum.openmod.org/t/define-shortage-in-oemof/2919/5

adnanalakori requested a review from smartie2076 November 30, 2021 11:17

smartie2076 reviewed Nov 30, 2021

View reviewed changes

inputs/timeseries/test_site.csv Outdated Show resolved Hide resolved

adnanalakori closed this Nov 30, 2021

adnanalakori reopened this Nov 30, 2021

smartie2076 reviewed Dec 1, 2021

View reviewed changes

adnanalakori mentioned this pull request Dec 1, 2021

Feature critical demand #166

Closed

adnanalakori force-pushed the feature-critical-demand branch from 4d21c9e to 1ca9b2e Compare January 13, 2022 14:00

smartie2076 reviewed Mar 15, 2022

View reviewed changes

adnanalakori commented Mar 16, 2022

View reviewed changes

src/constants.py Outdated Show resolved Hide resolved

src/constants.py Outdated Show resolved Hide resolved

src/constants.py Outdated Show resolved Hide resolved

src/constants.py Outdated Show resolved Hide resolved

src/D0_process_input.py Outdated Show resolved Hide resolved

Bachibouzouk added 4 commits April 4, 2022 12:46

Rename variable experiment to experiment_id

44de58b

Enable reading critical demand headers from timeseries file

f30e989

Update critical timeseries if FILE_INDEX is None

c788de5

Update critical timeseries if FILE_INDEX is not None

5d21820

Create a function to update the demand and not repeat code

Bachibouzouk added 5 commits April 4, 2022 13:30

Implement shortage in the case of critical demand

a0560e0

Not exactly sure it is the right implementation, need to check that and modify if needed

Compute total demand including critical demand as well

63b9690

Changed input files for critical demand

cff3836

Remaining TODOs

315fc63

Add unwanted files to .gitignore

16a676d

Bachibouzouk force-pushed the feature-critical-demand branch from 8c3ac8a to 16a676d Compare April 4, 2022 11:36

Bachibouzouk reviewed Apr 4, 2022

View reviewed changes

adnanalakori commented Apr 5, 2022

View reviewed changes

src/G1_oemof_create_model.py Outdated Show resolved Hide resolved

Bachibouzouk force-pushed the feature-critical-demand branch from b94124e to 16a676d Compare April 6, 2022 11:03

adnanalakori commented Apr 7, 2022

View reviewed changes

adnanalakori commented Apr 12, 2022

View reviewed changes

adnanalakori commented Apr 26, 2022

View reviewed changes

Bachibouzouk added 4 commits May 13, 2022 12:23

Add possibility to include critical constraint in input file

056b850

Return pcc feedin when created

8bcda2c

Prepare variables needed for critical demand constraint

4904bbd

The aim is to compute the energy balance between production and consumption of each AC and DC busses and make sure there is enough energy to fullfill criticial demand at all timesteps

Write critical demand constraint

271b4ac

Bachibouzouk force-pushed the feature-critical-demand branch from d7881b0 to 271b4ac Compare May 13, 2022 12:27

Bachibouzouk added 9 commits May 13, 2022 15:09

Fix computation of total demand

bd557b6

Fix shortage constraint

79bbc87

The triggering by critical constraint was wrong

Apply demand shortage only on non critical demand

3883ac4

Fix typo in constraint name

f928d4e

Modifiy the supplied demand in case of critical demand

9a2059e

TODO: adapt the code so that users not using critical demand do not recieve errors

Make sure the user knows that share_hybrid cannot be used

339be1c

if the critical demand option is on

Fix demand shortage function

5a53684

Add explicitely critical and non critical demand

7d63a2f

Also move the color dict as a constant in G4 module

WIP

40a2c38

Work in progress to implement https://forum.openmod.org/t/define-shortage-in-oemof/2919/5

		@@ -0,0 +1,28 @@
		******************************************************

		# TODO maybe important for critical
		# AD: We might leave this certain of shortage to assign to the non critical demand?

Feature critical demand #165

Are you sure you want to change the base?

Feature critical demand #165

Conversation

adnanalakori commented Nov 30, 2021 • edited Loading

smartie2076 commented Dec 1, 2021

smartie2076 left a comment

Choose a reason for hiding this comment

adnanalakori commented Dec 1, 2021 • edited Loading

smartie2076 commented Dec 1, 2021 • edited Loading

adnanalakori commented Dec 1, 2021 • edited Loading

smartie2076 commented Dec 1, 2021

smartie2076 commented Dec 1, 2021

smartie2076 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adnanalakori commented Mar 29, 2022 • edited Loading

smartie2076 commented Mar 29, 2022 • edited Loading

adnanalakori commented Mar 31, 2022

adnanalakori commented Mar 31, 2022

adnanalakori commented Mar 31, 2022

adnanalakori commented Mar 31, 2022 • edited Loading

smartie2076 commented Mar 31, 2022

Sidenote, can also be moved into an own issue

smartie2076 commented Mar 31, 2022

smartie2076 commented Mar 31, 2022

Bachibouzouk commented Apr 4, 2022

smartie2076 commented Apr 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bachibouzouk Apr 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adnanalakori Apr 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adnanalakori Apr 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adnanalakori Apr 26, 2022 • edited Loading

Choose a reason for hiding this comment

smartie2076 commented Apr 26, 2022

adnanalakori commented Nov 30, 2021 •

edited

Loading

adnanalakori commented Dec 1, 2021 •

edited

Loading

smartie2076 commented Dec 1, 2021 •

edited

Loading

adnanalakori commented Dec 1, 2021 •

edited

Loading

adnanalakori commented Mar 29, 2022 •

edited

Loading

smartie2076 commented Mar 29, 2022 •

edited

Loading

adnanalakori commented Mar 31, 2022 •

edited

Loading

Bachibouzouk Apr 4, 2022 •

edited

Loading

adnanalakori Apr 25, 2022 •

edited

Loading

adnanalakori Apr 26, 2022 •

edited

Loading

adnanalakori Apr 26, 2022 •

edited

Loading