Fix needless hiding of emphasis markers already hidden by Org #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only needless, but buggy compared to what Org is doing.
|
@Kazark I like what you are doing here, and agree, we can probably make this code more elegant and clean up a lot of the related issues by using the default org-mode hiding methods. I have some ideas for this and will followup later with another PR. |
|
@rlister Cool, thanks. I see my PR is conflicted now. Should I resolve that, or is your subsequent PR going to make this one obsolete? |
|
I plan to merge this. If you want to fix the conflict feel free to go ahead, otherwise I will look at it later today. Should be straightforward. |
|
|
|
@Kazark Great, thanks! |
|
@rlister Thanks for accepting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix needless (and buggy, compared to Org's default behavior) hiding of emphasis markers already hidden by Org. I spent some time trying to figure out how to clean up the current "hide emphasis markers" algorithm, evening looking at
org.el, but couldn't figure it out (#12 is relevant here).