Skip to content

Conversation

@LianShuQuan
Copy link
Contributor

@LianShuQuan LianShuQuan commented Oct 26, 2025

Does n_parallel_agents means the number of active agents, and max_workers means the concurrent env operations?
If so, then
trajectory_generator() should use asyncio.Semaphore() like execute_tasks();
self.executor = ThreadPoolExecutor(max_workers=max_concurrency) should be modified in trajectory_generator();
self.n_parallel_agents = len(envs) should be deleted in update_envs_and_agents().

@jeffreysijuntan
Copy link
Contributor

Great catch. How about renaming max_workers to max_env_workers then?

@LianShuQuan
Copy link
Contributor Author

Great catch. How about renaming max_workers to max_env_workers then?

Sure. Should I only change max_workers to max_env_workers besides the initialization parameters in order to maintain compatibility with the initialization and usage code of AgentExecutionEngine?

@jeffreysijuntan
Copy link
Contributor

Yes, simply rename this parameters to max_env_workers to make it clearer.

@jeffreysijuntan jeffreysijuntan merged commit e2b9240 into rllm-org:main Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants