Add ConvolvePSF type #162
Merged
Add ConvolvePSF type #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this now, since it's been 2 months. If anyone still wants to review it feel free. However, I suspect people care more about the applications to Optical + Atmosphere, which are coming next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new composite PSF type, Convolve. This is I think the framework into which we can move the work that @aaronroodman et al have done on the OptAtmo type.
Now we can separately specify the two or three things we want to convolve the optical PSF by and the code will separately fit each with their own interpolation scheme, etc.
For now the tests just have a fixed Optical model which is convolved by a Kolmogorov/GP model. So my next task is to port over the OptAtmo code that fits for the aberrations into something that works in this framework.