C++ version of _solve_direct in BasisInterp #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this a PR yet? I get that this is just a draft, but that should normally be reserved for when you are working out CI issues on a mostly completed project. IMO, this should just be a branch you and Nate are working on together, not a PI that other people get notifications for. |
|
Sorry about that. I had the habit of doing that in my last job. Will avoid doing this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with Nate Lust, on accelerating Piff, he basically came to the same conclusion as me and that accelerating
PixelGrid+BasisInterpmeant accelerating_solve_directinBasisInterp. As I am not a C++ expert I went through the path of implementing it in JAX in this #166.Nate already implemented a version in C++ and Eigen that is faster than the pure python implementation even on a single core it looks like. I'll let him push his code on that branch and I'll make the test / unit test to validate the C++ implementation and clean the
_solve_directin regards of the last change I push (see if JAX is still worst it compared to the C++ implementation).Just putting this as a draft PR for the moment.
Not ready for review.