Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery.timeago.zh-CN.js #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

julianlam
Copy link

Cross-pull-request from NodeBB/NodeBB/pull/6522

@julianlam
Copy link
Author

julianlam commented May 30, 2018

Paging @kj415j45 for feedback, as he or she seems to have removed the older translation in the last commit to this file.

@rmm5t
Copy link
Owner

rmm5t commented May 30, 2018

This is a literal Google Translation of the preposition "from now," which I suspect is unlikely to be correct. Not to mention this change leaves the suffixFromNow by which the combination of the two is most certainly unlikely to be correct (I would guess).

Yes, if @kj415j45 could chime in on this, that would be great.

@rmm5t
Copy link
Owner

rmm5t commented May 30, 2018

/cc @a632079

@a632079
Copy link

a632079 commented Jun 2, 2018

FromNow means the Distance from the present time. 从现在开始 more emphasis on current time from before. 距现在 just focus on the amount of time between. I think it's better than the first

@kj415j45
Copy link
Contributor

kj415j45 commented Jun 3, 2018

@julianlam and @a632079 , related context: #335 . plz re-consider then choose the better one. btw, this PR is different from NodeBB/NodeBB#6522 . You forgot to set suffixFromNow to null

@julianlam
Copy link
Author

btw, this PR is different from NodeBB/NodeBB#6522 . You forgot to set suffixFromNow to null

This is not a problem. When this PR is merged I pull this version into NodeBB.

@kj415j45
Copy link
Contributor

kj415j45 commented Jun 3, 2018

This is not a problem. When this PR is merged I pull this version into NodeBB.

To be honest, I prefer my version: "你的支持者标签将在 3天 之后 过期"。
idk how to make the context compatible with your version 距现在 3天 or 距现在 3天 之前 (if you are on purpose)

@rmm5t
Copy link
Owner

rmm5t commented Jun 3, 2018

This is not a problem. When this PR is merged I pull this version into NodeBB.

Yes, it is a problem. I will not merge this PR until suffixFromNow is also made null. (Assuming these changes are even warranted).

@a632079
Copy link

a632079 commented Jun 5, 2018

@kj415j45 in most case such as posts, it means when it postes. It's a past time.
大多数情况, 例如发帖。 他代表的是距离现在发帖的时间间隔。 我觉得只使用 之后 太过于狭义。

@kj415j45
Copy link
Contributor

kj415j45 commented Jun 6, 2018

@a632079 , fromNow only apply to the time after now. When you post a post, this situation is almost impossible.

fromNow 的情况是 当前时间 先于 被timeago的时间,而发帖时一般不可能发生这种情况。

@a632079
Copy link

a632079 commented Jun 7, 2018

@kj415j45 community.nodebb.org NodeBB 使用了早期的翻译。 其中文时间被显示为: 从现在开始不到几分钟。 其 fromNow 被赋值为 从现在开始。 如果他们这是个错误调用, 我觉得我可以向他们提出修改申请。

@kj415j45
Copy link
Contributor

kj415j45 commented Jun 7, 2018

@a632079 , Could you give some screenshot of your context? I can't find it in your given web.

你能提供一下截屏吗,那个网页上我没看到相关的上下文(

@kj415j45
Copy link
Contributor

kj415j45 commented Jul 9, 2018

So, I keep my idea:

prefixFromNow: null,
suffixFromNow: "之后",

@a632079 @julianlam , waiting for your response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants