Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements bulk unnesting . #256

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Implements bulk unnesting . #256

merged 2 commits into from
Feb 7, 2024

Conversation

steven2308
Copy link
Collaborator

@steven2308 steven2308 commented Feb 2, 2024

Description

Describe the additions/improvements this PR contains.

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

Detailed summary

  • Updated the node version in GitHub workflows from 16 to 18.
  • Added new functions bulkTransferAllChildren and bulkTransferChildren to the RMRKBulkWriter contract.
  • Added imports for IERC7401 and IERC6454 in RMRKBulkWriter.sol.
  • Updated the bulkWriterFixture function in bulkWriter.ts to use the updated addresses.
  • Updated the beforeEach function in the test file to use the updated addresses.

The following files were skipped due to too many changes: test/bulkWriter.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

openzeppelin-code bot commented Feb 2, 2024

Implements bulk unnesting .

Generated at commit: 7d8398a663a5f016baa4d62d97e6c7eafda08fb0

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
5
24
29
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@steven2308 steven2308 merged commit e513e69 into dev Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant