Merge after 2.5.3. #267
Merged
Merge after 2.5.3. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMRKTokenHolder (IERC7590-Draft Implementation) now reverts if transferred ERC-20 balance is not the specified amount. Improves @dev comment on IERC7401, directOwnerOf method.
…ions and tokenIds on setters and getters.
No long uses structs as return values for batch getters. If a single attribute is sent on batch getter/setters it will use it for all collections and tokens.
Bumps [squirrelly](https://github.com/squirrellyjs/squirrelly) from 8.0.8 to 9.0.0. - [Release notes](https://github.com/squirrellyjs/squirrelly/releases) - [Commits](squirrellyjs/squirrelly@v8.0.8...v9.0.0) --- updated-dependencies: - dependency-name: squirrelly dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Interface was refactoring purely for ordering purposes.
Renames methods to set and get collection attributes metadata to make it explicit they are per collection.
Merge after 2.5.3.
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Yuripetusko
reviewed
Mar 19, 2024
| uint256 initBalance = erc20.balanceOf(address(this)); | ||
| erc20.transferFrom(msg.sender, address(this), amount); | ||
| uint256 newBalance = erc20.balanceOf(address(this)); | ||
| // Here you can either use the difference as the amount, or revert if the difference is not equal to the amount and you don't want to support transfer fees |
There was a problem hiding this comment.
to me this comment is not very clear tbh
There was a problem hiding this comment.
Turns out there are ERC20 tokens with "Tax". So you call token.transfer(10) but only 9.9 are sent.
Initially, the token holder was assuming that the transferred value was received, so the balances of the NFT would be 10, but the contract would actually only have 9.9 in this case.
To fix this there are 2 options:
- If the balance of the contract did not increase by the exact amount, then it reverts. (Safest, but does not support tokens with taxes).
- Instead of increasing the token's balance to what was supposedly transfer, only increase it by the actually increased balance.
I implemented 1.
There was a problem hiding this comment.
thanks, but I meant more about the comment :D maybe if I didn't get it, others won't too, so we should improve the comment
There was a problem hiding this comment.
Oh.. haha. I guess I'll just copy paste this explanation.
Yuripetusko
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update after v2.5.3
Checklist