Skip to content

Merge pull request #15 from rnestler/upgrade-parse-display #44

Merge pull request #15 from rnestler/upgrade-parse-display

Merge pull request #15 from rnestler/upgrade-parse-display #44

GitHub Actions / clippy succeeded Jan 3, 2024 in 0s

clippy

1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 1
Note 0
Help 0

Versions

  • rustc 1.68.2 (9eb3afe9e 2023-03-27)
  • cargo 1.68.2 (6feb7c9cf 2023-03-26)
  • clippy 0.1.68 (9eb3afe 2023-03-27)

Annotations

Check warning on line 97 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> src/lib.rs:94:1
   |
94 | / pub enum Data {
95 | |     MovieList(MovieList),
   | |     -------------------- the second-largest variant contains at least 40 bytes
96 | |     MovieDetails(MovieDetail),
   | |     ------------------------- the largest variant contains at least 744 bytes
97 | | }
   | |_^ the entire enum is at least 744 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
96 |     MovieDetails(Box<MovieDetail>),
   |                  ~~~~~~~~~~~~~~~~