test: add some for backgroundlayer (#591)

* add tests for Backgroundlayer * linting
rnmapbox · Jan 10, 2020 · cc508f6 · cc508f6
1 parent 4a93b5a
commit cc508f6
Show file tree

Hide file tree

Showing 8 changed files with 100 additions and 14 deletions.
diff --git a/__tests__/components/BackgroundLayer.test.js b/__tests__/components/BackgroundLayer.test.js
@@ -0,0 +1,52 @@
+import React from 'react';
+import {render} from 'react-native-testing-library';
+
+import BackgroundLayer from '../../javascript/components/BackgroundLayer';
+
+export const NATIVE_MODULE_NAME = 'RCTMGLBackgroundLayer';
+
+describe('BackgroundLayer', () => {
+  test('renders correctly with default props', () => {
+    const {queryByTestId} = render(<BackgroundLayer />);
+
+    const backgroundLayer = queryByTestId('rctmglBackgroundLayer');
+    const {props} = backgroundLayer;
+
+    expect(props.sourceID).toStrictEqual('DefaultSourceID');
+  });
+
+  test('renders correctly with custom props', () => {
+    const testProps = {
+      id: 'customId',
+      sourceID: 'customSourceId',
+      sourceLayerID: 'customSourceLayerId',
+      aboveLayerID: 'customAboveLayerId',
+      belowLayerID: 'customBelowLayerId',
+      layerIndex: 0,
+      filter: ['==', 'arbitraryFilter', true],
+      minZoomLevel: 3,
+      maxZoomLevel: 8,
+      style: {visibility: 'none'},
+    };
+
+    const {queryByTestId} = render(<BackgroundLayer {...testProps} />);
+    const backgroundLayer = queryByTestId('rctmglBackgroundLayer');
+    const {props} = backgroundLayer;
+
+    expect(props.id).toStrictEqual(testProps.id);
+    expect(props.sourceID).toStrictEqual(testProps.sourceID);
+    expect(props.sourceLayerID).toStrictEqual(testProps.sourceLayerID);
+    expect(props.aboveLayerID).toStrictEqual(testProps.aboveLayerID);
+    expect(props.belowLayerID).toStrictEqual(testProps.belowLayerID);
+    expect(props.layerIndex).toStrictEqual(testProps.layerIndex);
+    expect(props.filter).toStrictEqual(testProps.filter);
+    expect(props.minZoomLevel).toStrictEqual(testProps.minZoomLevel);
+    expect(props.maxZoomLevel).toStrictEqual(testProps.maxZoomLevel);
+    expect(props.reactStyle).toStrictEqual({
+      visibility: {
+        styletype: 'constant',
+        stylevalue: {type: 'string', value: testProps.style.visibility},
+      },
+    });
+  });
+});
diff --git a/__tests__/modules/offline/OfflineCreatePackOptions.test.js b/__tests__/modules/offline/OfflineCreatePackOptions.test.js
@@ -5,7 +5,10 @@ describe('OfflineCreatePackOptions', () => {
   const options = {
     name: 'test',
     styleURL: 'mapbox://fake-style-url',
-    bounds: [[0, 1], [2, 3]],
+    bounds: [
+      [0, 1],
+      [2, 3],
+    ],
     minZoom: 1,
     maxZoom: 22,
     metadata: {

diff --git a/__tests__/modules/offline/OfflinePack.test.js b/__tests__/modules/offline/OfflinePack.test.js
@@ -4,7 +4,10 @@ import OfflinePack from '../../../javascript/modules/offline/OfflinePack';
 
 describe('OfflinePack', () => {
   const fakeNativePack = {
-    bounds: [[0, 1], [2, 3]],
+    bounds: [
+      [0, 1],
+      [2, 3],
+    ],
     metadata: '{"name":"test"}',
   };
 

diff --git a/__tests__/modules/offline/offlineManager.test.js b/__tests__/modules/offline/offlineManager.test.js
@@ -7,7 +7,10 @@ describe('offlineManager', () => {
   const packOptions = {
     name: 'test',
     styleURL: 'mapbox://fake-style-url',
-    bounds: [[0, 1], [2, 3]],
+    bounds: [
+      [0, 1],
+      [2, 3],
+    ],
     minZoom: 1,
     maxZoom: 22,
   };

diff --git a/__tests__/modules/snapshot/SnapshotOptions.test.js b/__tests__/modules/snapshot/SnapshotOptions.test.js
@@ -53,7 +53,10 @@ describe('SnapshotOptions', () => {
 
   it('should create options with bounds', () => {
     const expectedOptions = {
-      bounds: [[1, 2], [3, 4]],
+      bounds: [
+        [1, 2],
+        [3, 4],
+      ],
       width: 400,
       height: 600,
       styleURL: NativeModules.MGLModule.StyleURL.Light,

diff --git a/__tests__/utils/BridgeValue.test.js b/__tests__/utils/BridgeValue.test.js
@@ -5,7 +5,10 @@ describe('BridgeValue', () => {
     const bridgeValue = new BridgeValue([1, 2]);
     expect(bridgeValue.toJSON()).toEqual({
       type: 'array',
-      value: [{type: 'number', value: 1}, {type: 'number', value: 2}],
+      value: [
+        {type: 'number', value: 1},
+        {type: 'number', value: 2},
+      ],
     });
   });
 
@@ -24,7 +27,10 @@ describe('BridgeValue', () => {
     const bridgeValue = new BridgeValue([true, false]);
     expect(bridgeValue.toJSON()).toEqual({
       type: 'array',
-      value: [{type: 'boolean', value: true}, {type: 'boolean', value: false}],
+      value: [
+        {type: 'boolean', value: true},
+        {type: 'boolean', value: false},
+      ],
     });
   });
 
@@ -40,7 +46,10 @@ describe('BridgeValue', () => {
         {
           type: 'hashmap',
           value: [
-            [{type: 'string', value: 'prop1'}, {type: 'number', value: 1}],
+            [
+              {type: 'string', value: 'prop1'},
+              {type: 'number', value: 1},
+            ],
           ],
         },
         {
@@ -55,7 +64,10 @@ describe('BridgeValue', () => {
         {
           type: 'hashmap',
           value: [
-            [{type: 'string', value: 'prop3'}, {type: 'boolean', value: false}],
+            [
+              {type: 'string', value: 'prop3'},
+              {type: 'boolean', value: false},
+            ],
           ],
         },
       ],
@@ -144,8 +156,14 @@ describe('BridgeValue', () => {
     expect(bridgeValue.toJSON()).toEqual({
       type: 'hashmap',
       value: [
-        [{type: 'string', value: 'prop1'}, {type: 'string', value: 'value1'}],
-        [{type: 'string', value: 'prop2'}, {type: 'number', value: 2}],
+        [
+          {type: 'string', value: 'prop1'},
+          {type: 'string', value: 'value1'},
+        ],
+        [
+          {type: 'string', value: 'prop2'},
+          {type: 'number', value: 2},
+        ],
       ],
     });
   });

diff --git a/javascript/components/BackgroundLayer.js b/javascript/components/BackgroundLayer.js
@@ -74,7 +74,13 @@ class BackgroundLayer extends AbstractLayer {
   };
 
   render() {
-    return <RCTMGLBackgroundLayer ref="nativeLayer" {...this.baseProps} />;
+    return (
+      <RCTMGLBackgroundLayer
+        testID="rctmglBackgroundLayer"
+        ref="nativeLayer"
+        {...this.baseProps}
+      />
+    );
   }
 }
 

diff --git a/javascript/utils/BridgeValue.js b/javascript/utils/BridgeValue.js
@@ -64,9 +64,7 @@ export default class BridgeValue {
       value = this.rawValue;
     } else {
       throw new Error(
-        `[value - ${
-          this.rawValue
-        }] BridgeValue must be a primitive/array/object`,
+        `[value - ${this.rawValue}] BridgeValue must be a primitive/array/object`,
       );
     }