added option to switch ScaleBar MetricUnits #3422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
mfazekas
requested changes
Mar 24, 2024
There was a problem hiding this comment.
@gongdao123 thanks much, looks good to me, the only issue is the default value on android. It should be optional or just use the same default as the mapbox
| @@ -1305,12 +1305,15 @@ open class RNMBXMapView(private val mContext: Context, var mManager: RNMBXMapVie | |||
| } | |||
|
|
|||
| var mScaleBarSettings = OrnamentSettings(enabled = false) | |||
|
|
|||
| var mScaleBarIsMetricUnits = false | |||
There was a problem hiding this comment.
Not sure about the default, value.
Currently it depends on the locale
https://docs.mapbox.com/android/maps/api/11.2.1/mapbox-maps-android/com.mapbox.maps.plugin.scalebar/-locale-unit-resolver/is-metric-system.html
https://docs.mapbox.com/ios/maps/api/11.0.0/documentation/mapboxmaps/scalebarviewoptions/usemetricunits/
with this PR it will default to imperial.
There was a problem hiding this comment.
Good point, let me update the pr.
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
gongdao123
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2983
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reprocuce the issue you're fixing