Renamed libsexp to libsexpp; integrated an option to use libsexpp provided by the system #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maxirmx
commented
Jun 23, 2023
•
maxirmx
commented
- Renamed libsexp to libsexpp (name conflict libsexp (rnpgp/sexp and mjsottile/sfsexp) sexpp#45, Rename repository to sexpp sexpp#49)
- Integrated an option to use libsexpp provided by the system (add option to build with system sexp library #2102)
- Bumped install-nix-action version (macOS Nix builld is broken #2104)
maxirmx
changed the title
maxirmx
force-pushed
the
maxirmx-system-sexp
branch
from
7be61a7 to
e65e510
Compare
maxirmx
changed the title
maxirmx
changed the title
maxirmx
force-pushed
the
maxirmx-system-sexp
branch
from
5309cda to
c1357ef
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2103 +/- ##
==========================================
- Coverage 83.82% 83.81% -0.01%
==========================================
Files 161 161
Lines 32405 32405
==========================================
- Hits 27163 27161 -2
- Misses 5242 5244 +2
☔ View full report in Codecov by Sentry. |
maxirmx
force-pushed
the
maxirmx-system-sexp
branch
3 times, most recently
from
62fb505 to
a416ef8
Compare
maxirmx
changed the title
maxirmx
force-pushed
the
maxirmx-system-sexp
branch
2 times, most recently
from
3d3c12b to
dcccf5e
Compare
maxirmx
force-pushed
the
maxirmx-system-sexp
branch
4 times, most recently
from
1c571cc to
6f110b0
Compare
maxirmx
force-pushed
the
maxirmx-system-sexp
branch
from
6f110b0 to
9206d03
Compare
ronaldtse
approved these changes
Jun 28, 2023
|
Thank you @maxirmx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.