Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS nix CI #2105

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

ribose-jeffreylau
Copy link
Contributor

closes #2104

@ribose-jeffreylau ribose-jeffreylau self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (32149be) 83.81% compared to head (29db234) 83.81%.

❗ Current head 29db234 differs from pull request most recent head d0bb1c5. Consider uploading reports for the commit d0bb1c5 to get more accurate results

Additional details and impacted files
@@                                Coverage Diff                                @@
##           antonsviridenko-1980-ripemd160-def-prov-openssl3    #2105   +/-   ##
=================================================================================
  Coverage                                             83.81%   83.81%           
=================================================================================
  Files                                                   161      161           
  Lines                                                 32395    32405   +10     
=================================================================================
+ Hits                                                  27151    27161   +10     
  Misses                                                 5244     5244           
Impacted Files Coverage Δ
src/lib/crypto/backend_version.cpp 73.91% <ø> (ø)
src/tests/utils-rnpcfg.cpp 100.00% <ø> (ø)
src/rnpkeys/rnpkeys.cpp 91.03% <100.00%> (+0.25%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ni4
Copy link
Contributor

ni4 commented Jun 27, 2023

@ribose-jeffreylau Should not this be a single commit to main branch instead of 10 to the rnpgp:antonsviridenko-1980-ripemd160-def-prov-openssl3 ?

@ribose-jeffreylau ribose-jeffreylau changed the base branch from antonsviridenko-1980-ripemd160-def-prov-openssl3 to main June 28, 2023 01:59
@ribose-jeffreylau
Copy link
Contributor Author

@ribose-jeffreylau Should not this be a single commit to main branch instead of 10 to the rnpgp:antonsviridenko-1980-ripemd160-def-prov-openssl3 ?

Ah, retargeted to main branch now. Thanks!

@ribose-jeffreylau ribose-jeffreylau requested a review from ni4 June 28, 2023 02:04
@ribose-jeffreylau ribose-jeffreylau changed the title Fix macOS nix Fix macOS nix CI Jun 28, 2023
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ni4
Copy link
Contributor

ni4 commented Jun 28, 2023

Merging with 1 approval as CI-only.

@ni4 ni4 merged commit 1b7b0ba into rnpgp:main Jun 28, 2023
@ribose-jeffreylau ribose-jeffreylau deleted the ribose-jeffreylau-2104-macos-nix branch November 6, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build continuous integration Any issues pertaining to CI, e.g. GHA regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS Nix builld is broken
2 participants