Add CI script to manually build tarballs for the releases.

[ni4]

It could be automated/refactored in some way (like for tag push), however let's have at least manual one for now.
Related to #2227

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (3c42d77) to head (02bf6ee).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2228   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         107      107           
  Lines       23168    23168           
=======================================
  Hits        19378    19378           
  Misses       3790     3790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ribose-jeffreylau]

Thanks @ni4 ! Left some suggestions for you... :)

[ribose-jeffreylau]

Better to enclose variables in double quotes:

-RNP_TGZ=$(echo ${RNP_BLD}/*.tar.gz)
+RNP_TGZ=$(echo "${RNP_BLD}"/*.tar.gz)

Fine for now, but could break the tar command below if somehow there is more than one .tar.gz present in the $RNP_BLD directory.

Quick and dirty 2nd take:

-RNP_TGZ=$(echo ${RNP_BLD}/*.tar.gz)
+RNP_TGZ=$(find "${RNP_BLD}" -maxdepth 1 -type f -name '*.tar.gz' | head -n 1)

[ni4]

Thanks, fixed!

[ribose-jeffreylau]

Better to enclose variables in double quotes:

-RNP_UNP=$(echo ${RNP_CHK}/*)
+RNP_UNP=$(echo "${RNP_CHK}"/*)

or, to prevent from returning multiple directories:

-RNP_UNP=$(echo ${RNP_CHK}/*)
+RNP_UNP=$(find "${RNP_CHK}" -maxdepth 1 -type d | head -n 1)

[ni4]

Thanks, fixed!

[ribose-jeffreylau]

Better to enclose variables in double quotes:

-cmake -B ${RNP_CHK}/build -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=ON "${RNP_UNP}"
+cmake -B "${RNP_CHK}"/build -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=ON "${RNP_UNP}"

[ni4]

Thanks, fixed!

[ribose-jeffreylau]

Better to enclose variables in double quotes:

-cmake --build ${RNP_CHK}/build --parallel "$(nproc)"
+cmake --build "${RNP_CHK}"/build --parallel "$(nproc)"

[ni4]

Thanks, fixed!

[ribose-jeffreylau]

Prefer to direct error messages to stderr:

-echo "Error: artifacts dir ${RNP_ART} doesn't exist. Create or mount it before running the script."
+>&2 echo "Error: artifacts dir ${RNP_ART} doesn't exist. Create or mount it before running the script."

[ni4]

Thanks, fixed!

[ni4]

Thanks, @ribose-jeffreylau ! Fixed and re-pushed.

[ribose-jeffreylau]

Thanks @ni4!

[antonsviridenko]

Does it build the source tarball or the binary one?

[antonsviridenko]

There is one failing test...

[ni4]

Does it build the source tarball or the binary one?

It builds (and checks) source tarball, so it could be uploaded to the release artifacts. At some point it would be upgraded to run automatically on tag push or PR merge to the release branch :-)

There is one failing test...

Thanks, re-run it.

[maxirmx]

The rationale behind ci-legacy folder was to stash there unused ci scripts and remove this folder eventually (or optionally)

Please consider moving this script to ci folder

[ni4]

@maxirmx Oh, sure. Thanks for noticing.

[ni4]

@maxirmx Is it good to merge now?

[maxirmx]

Thank you