Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero-length input in rnp_input_from_memory() #2246

Merged

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Jun 18, 2024

fixes #2173

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (3d45a6b) to head (e8e7c35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   84.00%   84.01%           
=======================================
  Files         113      113           
  Lines       23066    23069    +3     
=======================================
+ Hits        19377    19381    +4     
+ Misses       3689     3688    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 self-requested a review June 19, 2024 12:09
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments.

src/lib/rnp.cpp Outdated Show resolved Hide resolved
src/tests/ffi-enc.cpp Show resolved Hide resolved
@desvxx desvxx force-pushed the desvxx-2173-change-rnp_input_from_memory-behaviour branch 5 times, most recently from be4038e to d4f25a0 Compare June 26, 2024 22:25
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the review comments.

src/lib/rnp.cpp Outdated Show resolved Hide resolved
src/tests/ffi-enc.cpp Outdated Show resolved Hide resolved
src/tests/ffi-enc.cpp Outdated Show resolved Hide resolved
src/tests/ffi-enc.cpp Show resolved Hide resolved
@desvxx desvxx force-pushed the desvxx-2173-change-rnp_input_from_memory-behaviour branch 2 times, most recently from 841674a to 02e1cfa Compare July 1, 2024 17:51
@desvxx desvxx force-pushed the desvxx-2173-change-rnp_input_from_memory-behaviour branch 3 times, most recently from f9b4840 to 1858b8b Compare August 29, 2024 12:06
@desvxx desvxx force-pushed the desvxx-2173-change-rnp_input_from_memory-behaviour branch from 1858b8b to e8e7c35 Compare September 7, 2024 13:54
@desvxx desvxx requested a review from ni4 September 7, 2024 18:34
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@desvxx desvxx merged commit abec6c7 into rnpgp:main Sep 16, 2024
123 checks passed
@desvxx desvxx deleted the desvxx-2173-change-rnp_input_from_memory-behaviour branch September 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encryption and decryption of zero length message raise error
3 participants