Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silent autoupgrade of weak cipher to the more secure one when exp… #2295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Dec 2, 2024

fixes #1810

@desvxx desvxx force-pushed the desvxx-1810-sha1-autoupgrade branch 2 times, most recently from 8832dad to b40709a Compare December 2, 2024 22:40
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (ddcbaa9) to head (cd8d936).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2295   +/-   ##
=======================================
  Coverage   84.81%   84.82%           
=======================================
  Files         116      116           
  Lines       23346    23353    +7     
=======================================
+ Hits        19802    19809    +7     
  Misses       3544     3544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desvxx desvxx force-pushed the desvxx-1810-sha1-autoupgrade branch 2 times, most recently from 1fe3ca1 to a426e64 Compare December 4, 2024 21:46
@desvxx desvxx force-pushed the desvxx-1810-sha1-autoupgrade branch from a426e64 to cd8d936 Compare December 4, 2024 22:25
@desvxx desvxx requested a review from ni4 December 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that changing of the key expiration works for SHA-1 selfsigs and updates hash to the stronger one.
1 participant