Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Faraday dependency and move to depending on Yammer's Yam gem #9

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

synth
Copy link

@synth synth commented Mar 21, 2013

I figured it would be more reliable to use Yammer's Yam gem to handle the low level requests, but I liked your high level abstraction, so I made this gem depend on Yam instead of calling Faraday directly.

Definitely needs some code review though, but its working for me on my production app now...

@tiabas
Copy link

tiabas commented Apr 8, 2013

Might you like to checkout a version of the Yammer gem that I have been working on. https://github.com/tiabas/yammer-client

@synth
Copy link
Author

synth commented Apr 8, 2013

@tiabas this looks similar to roadly's yammer gem, no? I still see an advantage to depending on Yammer's own yam gem so that if something like the endpoint changes, downstream dependencies will be updated right away rather than relying on third party gem's to update themselves. The api you have built looks nice though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants