-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gitlab plugins build #115
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
Rate Limit Exceeded@rustatian has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 14 minutes and 30 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, convert this PR to a draft and then mark it as ready for review again to re-trigger the review. Alternatively, you can push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per repository. WalkthroughThis pull request introduces the use of the Changes
TipsChat with CodeRabbit Bot (
|
Signed-off-by: Valery Piashchynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 4
Files ignored due to filter (1)
- velox_rr_v2023.toml
Files selected for processing (4)
- github/parse_test.go (2 hunks)
- github/pool.go (1 hunks)
- gitlab/repo.go (1 hunks)
- modulesInfo.go (2 hunks)
Files skipped from review due to trivial changes (1)
- github/parse_test.go
Additional comments (Suppressed): 8
gitlab/repo.go (7)
102-103: No changes detected. The error handling for bad response status remains the same.
106-108: The check for the number of commits has been updated to also handle the case where there are more than one commit. This is a good addition for ensuring that only one commit is selected.
110-113: A new check has been added to ensure that the commit SHA is not too short. This is a good addition for ensuring data integrity.
115-116: The commit SHA is now being truncated to the first 12 characters to comply with go.mod pseudo format specifications. This is a good change for ensuring compatibility with go.mod.
118-121: A new check has been added to ensure that the commit date is not nil. This is a good addition for ensuring data integrity.
123-123: The
velox.ParseModuleInfo
function is now being used to generate a pseudo version. This is a good change for ensuring accurate pseudo version generation.125-126: No changes detected. The handling for replacement paths remains the same.
github/pool.go (1)
- 153-154: The new code is using the first 12 characters of the commit SHA for the
Version
andPseudoVersion
. Ensure that this truncation does not cause any issues with versioning or conflict resolution. Also, verify that thevelox.ParseModuleInfo
function is compatible with the rest of your codebase and provides the same functionality as the oldparseModuleInfo
function.
Signed-off-by: Valery Piashchynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
Refactor:
parseModuleInfo
function withvelox.ParseModuleInfo
ingithub/parse_test.go
andgithub/pool.go
for improved modularity and maintainability.New Feature:
ModulesInfo
struct and associated functions inmodulesInfo.go
to extract version information from module names.Bug Fix:
gitlab/repo.go
'sGetPluginsModData
function to handle edge cases related to commit count, commit SHA length, and commit date.Chore:
.github/workflows/linux.yml
to trigger on pull requests to themaster
branch, enhancing CI/CD pipeline.