Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RR build by Velox GitHub test #126

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Dec 14, 2023

Reason for This PR

  • Additional tests

Description of Changes

  • Add installation of the latest Velox version.
  • Build RR by Velox.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Chores

    • Updated the GitHub Actions workflow to include a new job for building the RoadRunner component on Linux.
  • Documentation

    • Confirmed no changes to public API declarations.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added A-ci Area: CI CD C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Dec 14, 2023
@rustatian rustatian requested a review from wolfy-j December 14, 2023 14:08
@rustatian rustatian self-assigned this Dec 14, 2023
Copy link

coderabbitai bot commented Dec 14, 2023

Walkthrough

The changes introduce a new job in a GitHub Actions workflow specific to Linux builds. This job is designed to set up the Go environment, check out the repository's code, cache Go modules, install dependencies, and build the RoadRunner component. No changes have been made to the declarations of exported or public entities within the codebase.

Changes

File Path Change Summary
.github/workflows/linux.yml Added a new job build-sample-rr to set up Go, check out code, cache Go modules, install dependencies, and build RoadRunner

🐇✨
In the land of code and sun,
A new job has begun.
To build with care, so neat and fun,
RoadRunner's race is to be won. 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4baec73 and 71f321e.
Files ignored due to filter (1)
  • velox_rr_v2023.toml
Files selected for processing (1)
  • .github/workflows/linux.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/linux.yml

Signed-off-by: Valery Piashchynski <[email protected]>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 71f321e and 599e811.
Files selected for processing (1)
  • .github/workflows/linux.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/linux.yml

@rustatian rustatian merged commit 80c155a into master Dec 14, 2023
6 checks passed
@rustatian rustatian deleted the feature/github-build-tests branch December 14, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: CI CD C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant