Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace not working for the GitHub builder #129

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix: replace not working for the GitHub builder #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e77a1c
fix: properly set replace directive for GitHub
rustatian Jan 15, 2024
f7f0391
chore: formatting
rustatian Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions github/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ func (p *processor) run() {
modInfo.PseudoVersion = velox.ParseModuleInfo(modInfo.ModuleName, at.Time, commits[0].GetSHA()[:12])

if v.pluginCfg.Replace != "" {
modInfo.Replace = v.pluginCfg.Replace
p.log.Debug("[REPLACE REQUESTED]", zap.String("plugin", v.name), zap.String("path", v.pluginCfg.Replace))
}

Expand Down
7 changes: 4 additions & 3 deletions github/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
const (
rrOwner string = "roadrunner-server"
rrRepo string = "roadrunner"
zipExt string = ".zip"
)

/*
Expand Down Expand Up @@ -84,8 +85,8 @@ func (r *GHRepo) DownloadTemplate(tmp, version string) (string, error) { //nolin
name := path.Join(tmp, "roadrunner-server-"+version)
_ = os.RemoveAll(name)

r.log.Debug("[FLUSHING DATA ON THE DISK]", zap.String("path", name+".zip"))
f, err := os.Create(name + ".zip")
r.log.Debug("[FLUSHING DATA ON THE DISK]", zap.String("path", name+zipExt))
f, err := os.Create(name + zipExt)
if err != nil {
return "", err
}
Expand All @@ -101,7 +102,7 @@ func (r *GHRepo) DownloadTemplate(tmp, version string) (string, error) { //nolin

r.log.Debug("[SAVED]", zap.Int("bytes written", n))

rc, err := zip.OpenReader(name + ".zip")
rc, err := zip.OpenReader(name + zipExt)
if err != nil {
return "", err
}
Expand Down
2 changes: 1 addition & 1 deletion velox_rr_v2023.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ build_args = [
]

[roadrunner]
ref = "v2023.3.8"
ref = "v2023.3.9"

[github]
[github.token]
Expand Down
Loading