Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Object.values() #518

Conversation

rorymalcolm
Copy link
Contributor

@rorymalcolm rorymalcolm commented Apr 10, 2024

This adds support for Object.values(), alongside tests

@rorymalcolm
Copy link
Contributor Author

It seems likely we need to bump the Go version of this project - I can do that this week

Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, some small tweaks to improve maintainability.

builtin_object.go Outdated Show resolved Hide resolved
builtin_object.go Outdated Show resolved Hide resolved
@rorymalcolm rorymalcolm force-pushed the rorymalcolm/support-object-values-keys branch from 728f0da to c4200f1 Compare April 11, 2024 13:58
@rorymalcolm
Copy link
Contributor Author

Thanks for the PR, some small tweaks to improve maintainability.

Applied!

@stevenh
Copy link
Collaborator

stevenh commented Apr 13, 2024

Could you rebase to pickup the fix for the check failures please @rorymalcolm

This adds support for `Object.values()`, alongside tests
@rorymalcolm rorymalcolm force-pushed the rorymalcolm/support-object-values-keys branch from c4200f1 to 946c802 Compare April 13, 2024 16:12
@rorymalcolm
Copy link
Contributor Author

Could you rebase to pickup the fix for the check failures please @rorymalcolm

Done - was going to try get rorymalcolm#1 up today but you beat me to it - thanks so much!

@stevenh stevenh merged commit 1ca7723 into robertkrimen:master Apr 13, 2024
2 checks passed
@rorymalcolm rorymalcolm deleted the rorymalcolm/support-object-values-keys branch April 15, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants