Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries reports work with Birkhoff #18

Closed
wants to merge 17 commits into from

Conversation

robfalck
Copy link
Owner

@robfalck robfalck commented Feb 1, 2024

Summary

  • Refactored timeseries report so that it doesn't need a Problem instance.
  • Moved time, state, parameter, and control options into actual Phase.options so that they are recorded.
  • Removed phase instantiation using from_phase argument.
  • Added Phase.duplicate() method.
  • Added some tex files that were missing from the JOSS folder.
  • Cleanup .gitignore.

Related Issues

Backwards incompatibilities

  • Phase init argument from_phase is no longer availalbe. Users should use Phase.duplicate() or Phase.get_simulation_phase()

New Dependencies

None

@coveralls
Copy link

coveralls commented Feb 1, 2024

Pull Request Test Coverage Report for Build 7747185958

  • -51 of 265 (80.75%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 92.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dymos/phase/simulation_phase.py 11 14 78.57%
dymos/visualization/timeseries/bokeh_timeseries_report.py 79 83 95.18%
dymos/phase/analytic_phase.py 20 25 80.0%
dymos/phase/phase.py 84 123 68.29%
Totals Coverage Status
Change from base Build 7741681294: 0.6%
Covered Lines: 34995
Relevant Lines: 37727

💛 - Coveralls

@robfalck robfalck closed this Aug 14, 2024
@robfalck robfalck deleted the timeseries_report_update branch August 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trajectory results report is empty for Birkhoff transcription.
2 participants