Compression bug fix

robgridley · Apr 4, 2016 · f71f01c · f71f01c
1 parent b562ef3
commit f71f01c
Showing 1 changed file with 6 additions and 22 deletions.
diff --git a/src/Zpl/Image.php b/src/Zpl/Image.php
@@ -114,6 +114,7 @@ protected function create($data)
     protected function encode()
     {
         $bitmap = null;
+        $lastRow = null;
 
         for ($y = 0; $y < $this->height; $y++) {
             $bits = null;
@@ -131,7 +132,8 @@ protected function encode()
                 $row .= sprintf('%02X', bindec($byte));
             }
 
-            $bitmap .= $this->compress($row);
+            $bitmap .= $this->compress($row, $lastRow);
+            $lastRow = $row;
         }
 
         return $bitmap;
@@ -141,11 +143,12 @@ protected function encode()
      * Compress a row of ASCII hexadecimal data.
      *
      * @param string $row
+     * @param string $lastRow
      * @return string
      */
-    protected function compress($row)
+    protected function compress($row, $lastRow)
     {
-        if ($this->matchesLastRow($row)) {
+        if ($row === $lastRow) {
             return ':';
         }
 
@@ -155,25 +158,6 @@ protected function compress($row)
         return $row;
     }
 
-    /**
-     * Determine if the specified row is the same as the last row.
-     *
-     * @param string $row
-     * @return bool
-     */
-    protected function matchesLastRow($row)
-    {
-        static $lastRow = null;
-
-        if ($row == $lastRow) {
-            return true;
-        }
-
-        $lastRow = $row;
-
-        return false;
-    }
-
     /**
      * Replace trailing zeros or ones with a comma (,) or exclamation (!) respectively.
      *