Skip to content

Commit

Permalink
Merge pull request #150 from robinst/changelog-2.0
Browse files Browse the repository at this point in the history
Add changelog entry for taglib-ruby 2.0.0
  • Loading branch information
jacobvosmaer authored Oct 28, 2024
2 parents dbe0581 + d3179aa commit 9c4f721
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 2.0.0
### Changed
- Regenerate SWIG wrapper code against TagLib 2.0.1. This breaks
compatibility with TagLib 1.x. You will get a compiler error if you
try to install taglib-ruby 2.x on a system that has TagLib 1.x.
Please use taglib-ruby 1.x if your system has TagLib 1.x, and
taglib-ruby 2.x if your system has TagLib 2.x.
- The optional `strip_others` argument to `TagLib::MPEG::File#save` no
longer takes a boolean value. It now uses the constants
`TagLib::File::StripOthers` and `TagLib::File::StripNone`.

### Removed
- `TagLib::MPEG::File#tag` has been removed because it no longer
exists in TagLib 2.x. Please use `TagLib::MPEG::File#id3v2_tag` or
`TagLib::MPEG::File#id3v1_tag`.

## 1.1.3 - 2022-12-29
### Changed
- Fix warning `warning: undefining the allocator of T_DATA class
Expand Down
10 changes: 1 addition & 9 deletions docs/taglib/mpeg.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ def self.open(filename, read_properties=true)
def initialize(filename, read_properties=true)
end

# Returns a tag that contains attributes from both the ID3v2 and
# ID3v1 tag, with ID3v2 attributes having precendence.
#
# @return [TagLib::Tag]
# @return [nil] if not present
def tag
end

# Returns the ID3v1 tag.
#
# @param create if a new tag should be created when none exists
Expand Down Expand Up @@ -88,7 +80,7 @@ def audio_properties
# ArgumentError.
#
# @return [Boolean] whether saving was successful
def save(tags=TagLib::MPEG::File::AllTags, strip_others=true)
def save(tags=TagLib::MPEG::File::AllTags, strip_others=TagLib::File::StripOthers)
end

# Strip the specified tags from the file. Note that this directly
Expand Down

0 comments on commit 9c4f721

Please sign in to comment.