Upgrade from TagLib 1 to TagLib 2 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a problem brought up in #129 (comment). If multiple versions of TagLib are installed and the user sets TAGLIB_DIR, then we should use only TAGLIB_DIR and not also check some default directories (like /usr/local).
Ignore default directories when TAGLIB_DIR is set
Use C++17 for TagLib 2.0
Update taglib-2 from main
This will help with the switch to TagLib 2 because that version has a dependency in a Git submodule.
Get TagLib 2.0.1 working
TagLib 2: ignore MP4 const iterator begin and end
robinst
approved these changes
Oct 26, 2024
| %include <taglib/tfile.h> | ||
|
|
||
| %ignore TagLib::FileRef::properties; |
There was a problem hiding this comment.
I've created an issue to support properties and complexProperties:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates taglib-ruby to work with TagLib 2. This breaks compatibility with TagLib 1.
This change does not introduce new features; we are only making sure that taglib-ruby can compile against TagLib 2.
We are doing this in preparation for releasing taglib-ruby 2.