Add point2d unit tests

robocin · Sep 17, 2023 · 43ca90f · 43ca90f
1 parent f87e75d
commit 43ca90f
Show file tree

Hide file tree

Showing 5 changed files with 768 additions and 8 deletions.
diff --git a/robocin/geometry/CMakeLists.txt b/robocin/geometry/CMakeLists.txt
@@ -3,3 +3,10 @@ robocin_cpp_library(
         HDRS point2d.h
         SRCS point2d.cpp
 )
+
+robocin_cpp_test(
+        NAME point2d_test
+        HDRS ../utility/internal/test/epsilon_injector.h
+        SRCS point2d_test.cpp
+        DEPS point2d
+)
diff --git a/robocin/geometry/README.md b/robocin/geometry/README.md
@@ -86,7 +86,7 @@ various methods and operators for manipulating and performing calculations with
 ### Comparison Operators
 
 - `bool operator==(const Point2D& other) const`: Equality operator that checks if two points are equal;
-- `std::three_way_comparable auto operator<=>(const Point2D& other) const`: Three-way comparison operator that compares
+- `auto operator<=>(const Point2D& other) const`: Three-way comparison operator that compares
   two points and returns their relative ordering;
 
 ### Swap

diff --git a/robocin/geometry/internal/point2d_internal.h b/robocin/geometry/internal/point2d_internal.h
@@ -6,6 +6,7 @@
 #ifndef ROBOCIN_GEOMETRY_POINT2D_INTERNAL_H
 #define ROBOCIN_GEOMETRY_POINT2D_INTERNAL_H
 
+#include <iterator>
 #include <type_traits>
 
 namespace robocin::point2d_internal {

diff --git a/robocin/geometry/point2d.h b/robocin/geometry/point2d.h
@@ -6,15 +6,15 @@
 #ifndef ROBOCIN_GEOMETRY_POINT2D_H
 #define ROBOCIN_GEOMETRY_POINT2D_H
 
+#include "robocin/geometry/internal/point2d_internal.h"
+#include "robocin/utility/fuzzy_compare.h"
+
 #include <cmath>
 #include <iostream>
 #include <numeric>
 #include <optional>
 #include <stdexcept>
 
-#include "robocin/geometry/internal/point2d_internal.h"
-#include "robocin/utility/fuzzy_compare.h"
-
 namespace robocin {
 
 template <class T>
@@ -120,7 +120,7 @@ struct Point2D {
     }
   }
 
-  inline constexpr std::three_way_comparable auto operator<=>(const Point2D& other) const {
+  inline constexpr auto operator<=>(const Point2D& other) const {
     if constexpr (has_epsilon_v<value_type>) {
       if (auto x_cmp = fuzzyCmpThreeWay(x, other.x); std::is_neq(x_cmp)) {
         return x_cmp;
@@ -208,7 +208,7 @@ struct Point2D {
   [[nodiscard]] constexpr Point2D rotatedCCW(value_type t) &&
     requires(std::floating_point<value_type>)
   {
-    return rotateCW(t), std::move(*this);
+    return rotateCCW(t), std::move(*this);
   }
   [[nodiscard]] constexpr Point2D rotatedCCW(value_type t) const&
     requires(std::floating_point<value_type>)
@@ -247,11 +247,11 @@ struct Point2D {
   {
     if constexpr (has_epsilon_v<value_type>) {
       if (value_type norm = this->norm(); not fuzzyIsZero(norm)) {
-        x *= norm, y *= norm;
+        x /= norm, y /= norm;
       }
     } else {
       if (value_type norm = this->norm()) {
-        x *= norm, y *= norm;
+        x /= norm, y /= norm;
       }
     }
   }