fix/banner #25
Merged
fix/banner #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix banner
Changes
headingkey was added;<Banner/>: component now takestranslateprop and takes heading text content from it. Heading text length is now shortened on desktop and laptop devices.How to test
Before testing, you must have Node and the Node Package Manager (NPM) installed on your machine.
Initial Setup
git clone https://github.com/robocin/robocin-website.git;npm install --legacy-peer-deps;git checkout fix/banner;npm run devto start the application locally;http://localhost:3000.End-to-end Tests
Check if the banner heading changes depending on the current language of the website.