chore: accountchooser.com shutdown (firebase#762)

Release updates on accountchooser.com warnings & fix some issues.
roboflow · Oct 12, 2020 · a9c367d · a9c367d
1 parent 540ddc0
commit a9c367d
Show file tree

Hide file tree

Showing 113 changed files with 562 additions and 3,325 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+* Removes all accountchooser.com dependencies and deprecates all related APIs now that it is operating in universal opt-out mode.
diff --git a/README.md b/README.md
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "firebaseui",
-  "version": "4.2.0",
+  "version": "2.5.1",
   "description": "Javascript library for customizable UI on top of Firebase SDK",
   "main": [
     "./dist/firebaseui.js",

diff --git a/demo/README.md b/demo/README.md
@@ -51,6 +51,17 @@ Then copy and paste the Web snippet code found in the console (either by clickin
 your web app" button in your Project overview, or clicking the "Web setup" button in the Auth page)
 in the `config.js` file.
 
+## Integrate One-tap sign-up with FirebaseUI (optional)
+
+If you want to integrate with
+[One-tap sign-up](https://developers.google.com/identity/one-tap/web/overview),
+you will also need the Google OAuth web client ID corresponding to that project
+which can be retrieved from the Google Cloud Console. This value will need to be
+populated in `CLIENT_ID`.
+The domain of the page has to also be whitelisted. Learn more on how to
+[get started with One-tap sign-up](https://developers.google.com/identity/one-tap/web/get-started).
+Skip this step, if you don't want to use One-tap sign-up with FirebaseUI.
+
 ## Deploy
 
 ### Option 1: Compile and use local FirebaseUI files

diff --git a/demo/public/app.js b/demo/public/app.js
@@ -66,7 +66,7 @@ function getUiConfig() {
         provider: firebase.auth.PhoneAuthProvider.PROVIDER_ID,
         recaptchaParameters: {
           size: getRecaptchaMode()
-        }
+        },
       },
       {
         provider: 'microsoft.com',

diff --git a/demo/public/sample-config.js b/demo/public/sample-config.js
@@ -20,6 +20,8 @@ var config = {
 };
 firebase.initializeApp(config);
 
+
 // Google OAuth Client ID, needed to support One-tap sign-up.
 // Set to null if One-tap sign-up is not supported.
-var CLIENT_ID = 'YOUR_OAUTH_CLIENT_ID';
+var CLIENT_ID =
+    'YOUR_OAUTH_CLIENT_ID';
diff --git a/externs/firebaseui-externs.js b/externs/firebaseui-externs.js
@@ -467,8 +467,8 @@ firebaseui.auth.AuthUIError.prototype.toJSON = function() {};
 
 
 /**
- * The FirebaseUI credential helpers available.
- *
+ * The FirebaseUI credential helpers available. `ACCOUNT_CHOOSER_COM` is
+ * deprecated and will be removed by Jan 31st, 2021.
  * @enum {string}
  */
 firebaseui.auth.CredentialHelper = {
@@ -487,8 +487,10 @@ firebaseui.auth.Config = function() {};
 
 /**
  * The accountchooser.com configuration when it is selected as credential
- * helper.
+ * helper. This is now a no-op and is deprecated and will be removed by
+ * Jan 31st, 2021.
  *
+ * @deprecated
  * @type {!Object|undefined}
  */
 firebaseui.auth.Config.prototype.acUiConfig;
@@ -508,7 +510,8 @@ firebaseui.auth.Config.prototype.autoUpgradeAnonymousUsers;
 firebaseui.auth.Config.prototype.callbacks;
 
 /**
- * Determines which credential helper to use. The default is accountchooser.com.
+ * Determines which credential helper to use. By default, no credential helper
+ * is selected.
  *
  * @type {!firebaseui.auth.CredentialHelper|undefined}
  */
@@ -752,6 +755,7 @@ firebaseui.auth.FederatedSignInOption = function() {};
  * The Auth method (typically the authorization endpoint) needed for one-tap
  * sign-up, eg: 'https://accounts.google.com'.
  *
+ * @deprecated
  * @type {string|undefined}
  */
 firebaseui.auth.FederatedSignInOption.prototype.authMethod;

diff --git a/javascript/ui/element/dialog.js b/javascript/ui/element/dialog.js
@@ -21,6 +21,7 @@ goog.provide('firebaseui.auth.ui.element.dialog');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.mdl');
 goog.require('goog.dom');
+goog.requireType('goog.ui.Component');
 
 
 

diff --git a/javascript/ui/element/idps.js b/javascript/ui/element/idps.js
@@ -21,6 +21,7 @@ goog.provide('firebaseui.auth.ui.element.idps');
 goog.require('firebaseui.auth.ui.element');
 goog.require('goog.asserts');
 goog.require('goog.dom.dataset');
+goog.requireType('goog.ui.Component');
 
 
 /**

diff --git a/javascript/ui/element/newpassword.js b/javascript/ui/element/newpassword.js
@@ -21,6 +21,7 @@ goog.provide('firebaseui.auth.ui.element.newPassword');
 goog.require('firebaseui.auth.soy2.strings');
 goog.require('firebaseui.auth.ui.element');
 goog.require('goog.dom.classlist');
+goog.requireType('goog.ui.Component');
 
 
 goog.scope(function() {

diff --git a/javascript/ui/element/recaptcha.js b/javascript/ui/element/recaptcha.js
@@ -19,6 +19,7 @@
 goog.provide('firebaseui.auth.ui.element.recaptcha');
 
 goog.require('firebaseui.auth.ui.element');
+goog.requireType('goog.ui.Component');
 
 
 goog.scope(function() {

diff --git a/javascript/ui/page/anonymoususermismatch.js b/javascript/ui/page/anonymoususermismatch.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/base.js b/javascript/ui/page/base.js
@@ -33,6 +33,7 @@ goog.require('goog.events.Event');
 goog.require('goog.object');
 goog.require('goog.soy');
 goog.require('goog.ui.Component');
+goog.requireType('goog.Promise');
 
 
 /**
@@ -123,6 +124,7 @@ firebaseui.auth.ui.page.IJ_DATA_ = {
 };
 
 
+
 /**
  * Base page custom event.
  * @param {string} type The event type.

diff --git a/javascript/ui/page/blank.js b/javascript/ui/page/blank.js
@@ -20,6 +20,7 @@ goog.provide('firebaseui.auth.ui.page.Blank');
 
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/callback.js b/javascript/ui/page/callback.js
@@ -20,6 +20,8 @@ goog.provide('firebaseui.auth.ui.page.Callback');
 
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.Promise');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/differentdeviceerror.js b/javascript/ui/page/differentdeviceerror.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emailchangerevoke.js b/javascript/ui/page/emailchangerevoke.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emaillinksigninconfirmation.js b/javascript/ui/page/emaillinksigninconfirmation.js
@@ -24,6 +24,7 @@ goog.require('firebaseui.auth.ui.element.email');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
 goog.require('goog.dom.selection');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emaillinksigninlinking.js b/javascript/ui/page/emaillinksigninlinking.js
@@ -21,6 +21,7 @@ goog.provide('firebaseui.auth.ui.page.EmailLinkSignInLinking');
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emaillinksigninlinkingdifferentdevice.js b/javascript/ui/page/emaillinksigninlinkingdifferentdevice.js
@@ -22,6 +22,7 @@ goog.provide('firebaseui.auth.ui.page.EmailLinkSignInLinkingDifferentDevice');
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emaillinksigninsent.js b/javascript/ui/page/emaillinksigninsent.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emailmismatch.js b/javascript/ui/page/emailmismatch.js
@@ -21,6 +21,7 @@ goog.provide('firebaseui.auth.ui.page.EmailMismatch');
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/emailnotreceived.js b/javascript/ui/page/emailnotreceived.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/federatedlinking.js b/javascript/ui/page/federatedlinking.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/notice.js b/javascript/ui/page/notice.js
@@ -35,6 +35,7 @@ goog.provide('firebaseui.auth.ui.page.VerifyAndChangeEmailSuccess');
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 

diff --git a/javascript/ui/page/passwordlinking.js b/javascript/ui/page/passwordlinking.js
@@ -24,6 +24,7 @@ goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.element.password');
 goog.require('firebaseui.auth.ui.page.Base');
 goog.require('goog.asserts');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/passwordrecovery.js b/javascript/ui/page/passwordrecovery.js
@@ -23,6 +23,7 @@ goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.email');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/passwordreset.js b/javascript/ui/page/passwordreset.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.element.newPassword');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/passwordsignin.js b/javascript/ui/page/passwordsignin.js
@@ -24,6 +24,7 @@ goog.require('firebaseui.auth.ui.element.email');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.element.password');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/passwordsignup.js b/javascript/ui/page/passwordsignup.js
@@ -25,6 +25,7 @@ goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.element.name');
 goog.require('firebaseui.auth.ui.element.newPassword');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/phonesigninfinish.js b/javascript/ui/page/phonesigninfinish.js
@@ -28,6 +28,7 @@ goog.require('firebaseui.auth.ui.element.resend');
 goog.require('firebaseui.auth.ui.page.Base');
 goog.require('goog.Timer');
 goog.require('goog.events');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/phonesigninstart.js b/javascript/ui/page/phonesigninstart.js
@@ -20,11 +20,14 @@ goog.provide('firebaseui.auth.ui.page.PhoneSignInStart');
 
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
+goog.require('firebaseui.auth.ui.element.dialog');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.element.phoneNumber');
 goog.require('firebaseui.auth.ui.element.recaptcha');
 goog.require('firebaseui.auth.ui.page.Base');
 goog.require('goog.dom.selection');
+goog.requireType('firebaseui.auth.data.country.LookupTree');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/providersignin.js b/javascript/ui/page/providersignin.js
@@ -18,6 +18,7 @@ goog.module('firebaseui.auth.ui.page.ProviderSignIn');
 goog.module.declareLegacyNamespace();
 
 const Base = goog.require('firebaseui.auth.ui.page.Base');
+const DomHelper = goog.requireType('goog.dom.DomHelper');
 const idps = goog.require('firebaseui.auth.ui.element.idps');
 const page = goog.require('firebaseui.auth.soy2.page');
 
@@ -32,7 +33,7 @@ class ProviderSignIn extends Base {
    *     is clicked.
    * @param {?function()=} opt_privacyPolicyCallback Callback to invoke when
    *     the Privacy Policy link is clicked.
-   * @param {?goog.dom.DomHelper=} domHelper Optional DOM helper.
+   * @param {?DomHelper=} domHelper Optional DOM helper.
    */
   constructor(
       onIdpClick, providerConfigs, opt_tosCallback, opt_privacyPolicyCallback,

diff --git a/javascript/ui/page/revertsecondfactoradditionsuccess.js b/javascript/ui/page/revertsecondfactoradditionsuccess.js
@@ -23,6 +23,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/selecttenant.js b/javascript/ui/page/selecttenant.js
@@ -18,6 +18,7 @@ goog.module('firebaseui.auth.ui.page.SelectTenant');
 goog.module.declareLegacyNamespace();
 
 const Base = goog.require('firebaseui.auth.ui.page.Base');
+const DomHelper = goog.requireType('goog.dom.DomHelper');
 const dataset = goog.require('goog.dom.dataset');
 const element = goog.require('firebaseui.auth.ui.element');
 const page = goog.require('firebaseui.auth.soy2.page');
@@ -33,7 +34,7 @@ class SelectTenant extends Base {
    *     ToS link is clicked.
    * @param {?function()=} privacyPolicyCallback Optional callback to invoke
    *     when the Privacy Policy link is clicked.
-   * @param {?goog.dom.DomHelper=} domHelper Optional DOM helper.
+   * @param {?DomHelper=} domHelper Optional DOM helper.
    */
   constructor(
       onTenantClick, tenantConfigs, tosCallback = undefined,

diff --git a/javascript/ui/page/signin.js b/javascript/ui/page/signin.js
@@ -24,6 +24,7 @@ goog.require('firebaseui.auth.ui.element.email');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
 goog.require('goog.dom.selection');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/spinner.js b/javascript/ui/page/spinner.js
@@ -20,6 +20,7 @@ goog.provide('firebaseui.auth.ui.page.Spinner');
 
 goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/ui/page/unsupportedprovider.js b/javascript/ui/page/unsupportedprovider.js
@@ -22,6 +22,7 @@ goog.require('firebaseui.auth.soy2.page');
 goog.require('firebaseui.auth.ui.element');
 goog.require('firebaseui.auth.ui.element.form');
 goog.require('firebaseui.auth.ui.page.Base');
+goog.requireType('goog.dom.DomHelper');
 
 
 /**

diff --git a/javascript/utils/cookiemechanism.js b/javascript/utils/cookiemechanism.js
@@ -65,7 +65,7 @@ firebaseui.auth.CookieMechanism =
    */
   set(key, value) {
     goog.net.cookies.set(
-        key, value, this.maxAge_, this.path_, this.domain_, this.secure_);
+      key, value, this.maxAge_, this.path_, this.domain_, this.secure_);
   }
 
   /**

diff --git a/javascript/utils/eventregister.js b/javascript/utils/eventregister.js
@@ -22,6 +22,7 @@ goog.provide('firebaseui.auth.EventRegister');
 
 goog.require('goog.array');
 goog.require('goog.events.EventTarget');
+goog.requireType('goog.events.Event');
 
 
 /**
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* Removes all accountchooser.com dependencies and deprecates all related APIs now that it is operating in universal opt-out mode.
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,6 +20,7 @@ goog.provide('firebaseui.auth.ui.page.Blank'); @@
     goog.require('firebaseui.auth.soy2.page');
     goog.require('firebaseui.auth.ui.page.Base');
+    goog.requireType('goog.dom.DomHelper');
     /**
@@ Expand Down @@