Revert "Depth estimation workflow block" #1196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelPeczek-Roboflow
requested review from
capjamesg,
grzegorz-roboflow,
hansent,
yeldarby and
probicheaux
as code owners
grzegorz-roboflow
approved these changes
Apr 17, 2025
codeflash-ai bot
added a commit
that referenced
this pull request
Apr 17, 2025
…rt-1175-depth-estimation-workflow-block`) To optimize the given Python program, we can make several improvements, mainly focusing on reducing the time spent in the `add_model` method. This includes reducing the repetitive calls to the `logger.debug` method and streamlining the model registration process. Below are the optimized versions of the classes. ### Changes and Optimizations. 1. **Improved Error Handling in `get_model`**. - Replaced the `if` statement with a `try-except` block to catch `KeyError` directly, which is more efficient than checking and then accessing the dictionary. 2. **Reduced Logger Calls in `add_model`**. - Moved the logger debug statements to only occur at necessary points, avoiding redundant calls. - Combined the final log message into one call rather than multiple scattered calls during the process. 3. **Streamlined Model Initialization in `add_model`**. - Pulled the model class retrieval and initialization outside the logger debug call to minimize calculation duplication, focusing on reducing lookup overhead. By reducing the number of logger debug calls, and optimizing model checks and retrievals, the overall performance of the `add_model` method is improved.
⚡️ Codeflash found optimizations for this PR📄 25% (0.25x) speedup for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1175
Fails CI
https://github.com/roboflow/inference/actions/runs/14512271092/job/40713493276
https://github.com/roboflow/inference/actions/runs/14512271088/job/40713515913
https://github.com/roboflow/inference/actions/runs/14512271047/job/40713522017
https://github.com/roboflow/inference/actions/runs/14512271091/job/40713518167
https://github.com/roboflow/inference/actions/runs/14512271088/job/40713517226
https://github.com/roboflow/inference/actions/runs/14512271083/job/40713512067
https://github.com/roboflow/inference/actions/runs/14512271115/job/40713518209
https://github.com/roboflow/inference/actions/runs/14512271047/job/40713522709
https://github.com/roboflow/inference/actions/runs/14512271091/job/40713519296
https://github.com/roboflow/inference/actions/runs/14512271088/job/40713518092
https://github.com/roboflow/inference/actions/runs/14512271091/job/40713520530
https://github.com/roboflow/inference/actions/runs/14512271088/job/40713519324
https://github.com/roboflow/inference/actions/runs/14512271115/job/40713520597