Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Using add-on modules page #296

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Update the Using add-on modules page #296

merged 1 commit into from
Sep 22, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Sep 1, 2024 •
edited
Loading

This PR updates the Using add-on modules page.

The changes are:

  • Separate supported, deprecated, and removed modules for clarity.
  • Add links to external documentation where possible.

@hoisie @brettchabot this PR officially deprecates the shadows-multidex module. Are you ok with that? This was discussed in robolectric/robolectric#9266, but no actual decision was made.

Screenshot 2024-09-03 at 13 20 14

utzcoz
utzcoz approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's time to deprecate it as Robolectric supports Android SDK 21+ now.

utzcoz
utzcoz reviewed Sep 1, 2024
View reviewed changes
docs/using-add-on-modules.md Outdated Show resolved Hide resolved
@MGaetan89 MGaetan89 force-pushed the update_using_add-ons branch from b50adbf to eda06c4 Compare September 1, 2024 07:41
utzcoz
utzcoz approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MGaetan89 MGaetan89 force-pushed the update_using_add-ons branch 3 times, most recently from fd4c1b2 to 8e27352 Compare September 8, 2024 06:59
@MGaetan89
Copy link
Member Author

Friendly ping @hoisie @brettchabot, to know if it's fine by your to deprecate shadows-multidex, so it can potentially be removed in a future version of Robolectric

@MGaetan89
Copy link
Member Author

MGaetan89 commented Sep 19, 2024 •
edited
Loading

FYI I'm opening PRs on various repositories to remove the shadows-multidex dependencies where possible: https://github.com/search?q=author%3AMGaetan89+%22Remove+Multidex+usages%22&type=pullrequests

I'm using this search query to find where it is used, and I'm selecting repositories that match the following criteria:

  • The repository is not archived.
  • The repository is not a fork (if the main repo is updated, then forks can cherry-pick the change if they are still maintained).
  • The repository was updated less than a year ago (I might increase this later).
  • The repository min SDK is 21 or higher.

@utzcoz
Copy link
Member

utzcoz commented Sep 22, 2024

@MGaetan89 Maybe this PR can keep the origin multidex shadow library state, and merge first. If we decide to deprecate this library, we can send a new PR to do it.

@MGaetan89
Update the Using add-on modules page
3f5353f 
This PR updates the [`Using add-on modules`](https://robolectric.org/using-add-on-modules/) page.

The changes are:
- Separate supported and legacy modules for clarity.
- Add links to external documentation where possible.

@hoisie @brettchabot this PR officially deprecates the `shadows-multidex` module. Are you ok with that?
This was discussed in robolectric/robolectric#9266, but no actual decision was made.
@MGaetan89
Copy link
Member Author

@MGaetan89 Maybe this PR can keep the origin multidex shadow library state, and merge first. If we decide to deprecate this library, we can send a new PR to do it.

Good idea. I've updated the PR accordingly

@MGaetan89 MGaetan89 merged commit a060ba3 into robolectric:master Sep 22, 2024
1 check passed
@MGaetan89 MGaetan89 deleted the update_using_add-ons branch September 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utzcoz utzcoz utzcoz approved these changes

@hoisie hoisie Awaiting requested review from hoisie

@brettchabot brettchabot Awaiting requested review from brettchabot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @utzcoz