Replace the contributing guide #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
include_contributing_guide
branch
from
465f694 to
a310264
Compare
MGaetan89
force-pushed
the
include_contributing_guide
branch
from
a310264 to
441ae67
Compare
This PR replaces the [contributing guide](https://robolectric.org/contributing/) to include the one from [robolectric/robolectric](https://github.com/robolectric/robolectric/blob/master/.github/CONTRIBUTING.md).
MGaetan89
force-pushed
the
include_contributing_guide
branch
from
441ae67 to
2df6a81
Compare
|
This can now be reviewed, as robolectric/robolectric#9574 has been merged. |
|
It's fine for me. But it's strange that Robolectric repository refers some links to robolectric.github.io, and robolectric.github.io refers some links to Robolectric repository. |
|
The perks of having two repositories 😅 |
utzcoz
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the contributing guide to include the one from robolectric/robolectric.
That guide is more useful on
robolectric/robolectric, since it is accessible when opening a PR.However, it is also useful here, since there is a
Contributingsection.This PR allows sharing the same document on both sides.
The downside is that a new build on this repo is required when updating the document on
robolectric/robolectricin order for the dedicated page to be updated.You can find the documentation for the syntax used here: https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#embedding-external-files