Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong urdf_path #47

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: wrong urdf_path #47

merged 1 commit into from
Jan 2, 2024

Conversation

lvjonok
Copy link
Contributor

@lvjonok lvjonok commented Jan 1, 2024

Good day!

There has been a problem in h1_description I have contributed recently, I aim to fix it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7378177645

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.81%
Totals Coverage Status
Change from base Build 7247255870: 0.0%
Covered Lines: 830
Relevant Lines: 840
💛 - Coveralls

@stephane-caron
Copy link
Member

stephane-caron commented Jan 2, 2024 •
edited
Loading

Oh, this should have been caught by unit tests. It wasn't because we forgot to add the description to the list in robot_descriptions/_descriptions.py. I'll do that and merge this PR.

@stephane-caron stephane-caron merged commit deb2a4c into robot-descriptions:main Jan 2, 2024
5 of 8 checks passed
@stephane-caron
Copy link
Member

Done, thank you for this fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvjonok @coveralls @stephane-caron