Orphan purchases #182
Open
Orphan purchases #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by non-framework classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a potential bug where the app dies before finishTransactions can be called. Then at next startup, RMStore will process transactions nobody has asked for and will just mark them as complete (since there will be no successBlock or failBlock to call).
This regularly happens on older devices if credit cards are denied or old, then the user needs to update their card info and switch away from the app (which then might be killed). Or the user just won't come back since filling out credit card info is such a hassle. When coming back (could be a week later), RMStore has nobody's block to call.