Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMU sensors: alignment real ergoCub/iCub w/ simulated one #636

Closed
Nicogene opened this issue Mar 28, 2024 · 10 comments · Fixed by #637, robotology/icub-models-generator#269 or icub-tech-iit/ergocub-software#232
Assignees

Comments

@Nicogene
Copy link
Member

Nicogene commented Mar 28, 2024

This PR:

Added the remapper for the imus that uses sensorNames that are not coherent with the actual sensor names of the exposed imu except for iCubGenova11.

embObjIMU exposes as sensor name the id if sensorName is not specified, and sensorName is present in only the iCubGenova11 imus xml.

Moreover, I noticed that on urdf side, iCub and ergoCub use different names for the imus:

Mandatory

  • @traversaro Stakeholder need: The sensor name used on simulator and real robot (either for iCub and ergoCub) must be coherent
  • sensorName must be added in all FT imu xml.

Nice to have

  • iCub and ergoCub uses the same sensor names

Nicer to have

This activity can be done in more steps, the mandatory points are the one more urgent, but they depend on if we want to "cleanup" the sensor name situation

cc @pattacini

@traversaro
Copy link
Member

fyi @robotology/iit-ami-scrum-masters when implemented this may affect configuration files on our side.

@martinaxgloria
Copy link
Contributor

As discussed in a private chat with @Nicogene, we decided to add the sensorName tag in all the FT IMUs XML files and the chosen names must be coherent with the simulated ones.

cc @Nicogene @pattacini @traversaro

@traversaro
Copy link
Member

Great! Do you think it could make sense to document this convention of the sensor names somewhere in the docs? We can just write down that its implementation is still work in progress, but at least to have a reference for the future.

@martinaxgloria
Copy link
Contributor

There are those pages in the doc for the sensors:

For each sensor belonging to a robot part there's a table with a column named Sensor Name. What about using this? Or we can add an extra column in these tables

cc @traversaro @Nicogene @pattacini

@traversaro
Copy link
Member

For each sensor belonging to a robot part there's a table with a column named Sensor Name. What about using this? Or we can add an extra column in these tables

I think that "sensor name" in the table is a bit misleading, as what is indicating is the prefix of the port that publish information about the reference sensors, not the sensor name, so I totally agree in using that column.

@martinaxgloria
Copy link
Contributor

cc @mfussi66 since he added this information to the documentation.

@martinaxgloria
Copy link
Contributor

martinaxgloria commented Apr 3, 2024

For the time being, I opened this PR:

to set a starting point for the real robots. The simulated ones will be modified taking this PR as a reference

@pattacini pattacini linked a pull request Apr 4, 2024 that will close this issue
@martinaxgloria
Copy link
Contributor

Since

has been merged, could we close this issue? I'll proceed to update iCub and ergoCub models according to that PR.

cc @Nicogene @pattacini

@martinaxgloria
Copy link
Contributor

@Nicogene
Copy link
Member Author

Nicogene commented Apr 4, 2024

Since

* [ IMU sensors: add sensorName tag in FT IMU xml  #637](https://github.com/robotology/robots-configuration/pull/637)

has been merged, could we close this issue? I'll proceed to update iCub and ergoCub models according to that PR.

cc @Nicogene @pattacini

Let's close it when also the models PR will be merged

I'll revive this PR:

https://github.com/icub-tech-iit/ergocub-software/pull/232

and open a new one on icub-models-generator

Put it ready for review and rebase it, it may be that you will face some conficts, once resolved please let me know when generating the V1_1 models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment